Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable3.0] Fix navigation icon bullet accessibility #3990

Closed
wants to merge 1 commit into from

Conversation

backportbot-nextcloud[bot]
Copy link

backport of #3960

use CheckboxBlankCircle as icon within the Action for icon bullet instead of AppNavigationIconBullet and AppNavigationDisabledCalendarIconBullet.

AppNavigationDisabledCalendarIconBullet is not needed anymore.

Signed-off-by: julia.kirschenheuter <[email protected]>

!Fixup tabulation

Signed-off-by: julia.kirschenheuter <[email protected]>
@backportbot-nextcloud backportbot-nextcloud bot added 3. to review Waiting for reviews blocked This ticket or PR is blocked by another one labels Feb 23, 2022
@backportbot-nextcloud backportbot-nextcloud bot added this to the v3.0.7 milestone Feb 23, 2022
@codecov
Copy link

codecov bot commented Feb 23, 2022

Codecov Report

Merging #3990 (083f45d) into stable3.0 (8dfa44e) will increase coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##             stable3.0    #3990      +/-   ##
===============================================
+ Coverage        29.66%   29.68%   +0.01%     
  Complexity         318      318              
===============================================
  Files              219      218       -1     
  Lines             7378     7375       -3     
  Branches           914      914              
===============================================
  Hits              2189     2189              
+ Misses            5189     5186       -3     
Flag Coverage Δ
javascript 20.80% <0.00%> (+0.01%) ⬆️
php 68.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ts/AppNavigation/CalendarList/CalendarListItem.vue 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff320e7...083f45d. Read the comment docs.

@ChristophWurst
Copy link
Member

stable3.0 won't be released anymore, stable3.1 takes over.

@ChristophWurst ChristophWurst deleted the backport/3960/stable3.0 branch February 23, 2022 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews blocked This ticket or PR is blocked by another one
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants