Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avatars for Rooms and Participants are broken #3099

Open
miaulalala opened this issue May 20, 2021 · 7 comments · May be fixed by #3101
Open

Avatars for Rooms and Participants are broken #3099

miaulalala opened this issue May 20, 2021 · 7 comments · May be fixed by #3101
Labels
1. to develop Accepted and waiting to be taken care of bug design Related to design, interface, interaction design, UX, etc. Feature: Scheduling Anything around scheduling meetings, free-busy, resources, attendees and so on papercut Annoying recurring issue with possibly simple fix.

Comments

@miaulalala
Copy link
Contributor

When adding a new participants, the avatars don't correctly resolve.

image

@miaulalala miaulalala added bug 0. to triage Pending approval or rejection labels May 20, 2021
tcitworld added a commit that referenced this issue May 20, 2021
Closes #3099

Signed-off-by: Thomas Citharel <[email protected]>
@ChristophWurst ChristophWurst added 1. to develop Accepted and waiting to be taken care of 3. to review Waiting for reviews and removed 0. to triage Pending approval or rejection labels May 26, 2021
@ChristophWurst ChristophWurst linked a pull request May 26, 2021 that will close this issue
@miaulalala miaulalala added 2. developing Work in progress and removed 3. to review Waiting for reviews 1. to develop Accepted and waiting to be taken care of labels Mar 21, 2022
@ChristophWurst ChristophWurst added 0. to triage Pending approval or rejection 1. to develop Accepted and waiting to be taken care of and removed 2. developing Work in progress 0. to triage Pending approval or rejection labels Mar 21, 2022
@ChristophWurst ChristophWurst added the Feature: Scheduling Anything around scheduling meetings, free-busy, resources, attendees and so on label Mar 21, 2022
@ChristophWurst ChristophWurst moved this to 📄 To do (5-20 entries) in 💌 📅 👥 Groupware team Mar 21, 2022
@ChristophWurst ChristophWurst added the design Related to design, interface, interaction design, UX, etc. label Mar 21, 2022
@Jerome-Herbinet
Copy link
Member

Jerome-Herbinet commented May 11, 2022

When adding a new participants, the avatars don't correctly resolve.

image

I confirm that this problem has existed for several years in Nextcloud Calendar, but also in Nextcloud Files (in sharing tab).

2022-05-11_15-43

@Jerome-Herbinet
Copy link
Member

This screenshot has been made on :

  • Nextcloud 23.0.3
  • Calendar 3.3.0

@brotkastn
Copy link

Hello,
i have the same Problem, and the Problem may be that it loads the "wrong" Avatar.

I use the LDAP-Backend, so i have weird User-IDs like "B8F13E54-AF45-44B8-BB02-A9594E7D39D2", but the avatar will get loaded via https://nextcloud.domain.de/avatar/User%20Name/64

If i change the Name to the User-ID, the avatar gets loaded.

Also, since the Upgrade to 24.0, the "find available times" popup does nothing - but i think this might be another bug...

Thank you,
Michael

@mrschaal

This comment was marked as off-topic.

@tcitworld

This comment was marked as off-topic.

@Jerome-Herbinet
Copy link
Member

Reminder if necessary of some information I wrote in one of my closed issues, mentioned here in may 2022 :

Analysis with the code inspector of my browser :

Looking at the HTML source code, here is a fairly easy to understand observation, which might suggest that the problem could (perhaps) be simple and quick to solve:
First look at the URL of the called avatar when it is displayed correctly (in the top right of the interface, or in the list of users of the instance): We see "/avatar/{username}/32?v=1".

  • "{username}" is what we use for example to connect to Nextcloud, on the login screen
  • 32?v=1" has no impact on whether or not the avatar is displayed correctly
    Then simply look at the URL of the avatars in the list of participants in an event:
    We see "/avatar/{display name}/32?v=1" ... including accents, spaces, etc ...

    Conclusion of this little analysis :
  • We know what is the expected URL (good) and what it corresponds to (username)
  • We know what the actual URL is (bad) and what it corresponds to (display name)

@st3iny
Copy link
Member

st3iny commented Apr 26, 2023

I totally get that this bug is causing frustration. From the surface it should be an easy fix.

However, I investigated this once some time ago and discovered that it is hard to distinguish between Nextcloud users on the particular server and "foreign" attendees. This distinction is important because it only makes sense to fetch the avatars of local users.

Maybe there were some changes implemented since then that would make this easier. It might be worth to give it another shot.

tcitworld added a commit that referenced this issue Apr 26, 2023
Closes #3099

Signed-off-by: Thomas Citharel <[email protected]>
ChristophWurst added a commit that referenced this issue Sep 6, 2023
Instead of broken user avatars. This is not a comprehensive fix but a
workaround for #3099, which is not trivial to fix.

Signed-off-by: Christoph Wurst <[email protected]>
ChristophWurst added a commit that referenced this issue Sep 6, 2023
Instead of broken user avatars. This is not a comprehensive fix but a
workaround for #3099, which is not trivial to fix.

Signed-off-by: Christoph Wurst <[email protected]>
backportbot-nextcloud bot pushed a commit that referenced this issue Sep 7, 2023
Instead of broken user avatars. This is not a comprehensive fix but a
workaround for #3099, which is not trivial to fix.

Signed-off-by: Christoph Wurst <[email protected]>
backportbot-nextcloud bot pushed a commit that referenced this issue Sep 7, 2023
Instead of broken user avatars. This is not a comprehensive fix but a
workaround for #3099, which is not trivial to fix.

Signed-off-by: Christoph Wurst <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of bug design Related to design, interface, interaction design, UX, etc. Feature: Scheduling Anything around scheduling meetings, free-busy, resources, attendees and so on papercut Annoying recurring issue with possibly simple fix.
Projects
Status: 📄 To do
Development

Successfully merging a pull request may close this issue.

7 participants