fix(scheduling): Use attendee placeholder avatars #5454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of broken user avatars. This is not a comprehensive fix but a workaround for #3099, which is not trivial to fix. Signed-off-by: Christoph Wurst <[email protected]>
ChristophWurst
added
3. to review
ChristophWurst
changed the title
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #5454 +/- ##
============================================
- Coverage 22.68% 22.64% -0.04%
- Complexity 387 395 +8
============================================
Files 240 241 +1
Lines 11811 11831 +20
Branches 2297 2297
============================================
Hits 2679 2679
- Misses 9132 9152 +20
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
tcitworld
approved these changes
Sep 6, 2023
miaulalala
approved these changes
Sep 7, 2023
|
/backport to stable4.5 |
backportbot-nextcloud
bot
added
the
backport-request
|
/backport to stable4.4 |
This was referenced Sep 7, 2023
backportbot-nextcloud
bot
removed
the
backport-request
|
/backport to stable3.5 |
backportbot-nextcloud
bot
added
the
backport-request
|
The backport to stable3.5 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable3.5
git pull origin stable3.5
# Create the new backport branch
git checkout -b fix/foo-stable3.5
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable3.5More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
|
/backport to stable3.5 |
ChristophWurst
removed
the
backport-request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of broken user avatars. This is not a comprehensive fix but a workaround for #3099, which is not trivial to fix.