Fix attendees avatars #3101
Fix attendees avatars #3101
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #3101 +/- ##
============================================
+ Coverage 22.59% 22.60% +0.01%
- Complexity 373 374 +1
============================================
Files 236 236
Lines 11475 11495 +20
Branches 2149 2150 +1
============================================
+ Hits 2593 2599 +6
- Misses 8882 8896 +14
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
| return contact?.isUser ? undefined : contact?.avatar | ||
| }, | ||
|
|
||
| isContactAnUser: (state) => (uri) => { |
There was a problem hiding this comment.
| isContactAnUser: (state) => (uri) => { | |
| isContactAUser: (state) => (uri) => { |
https://english.stackexchange.com/questions/105116/is-it-a-user-or-an-user
|
Hello! I would like to ask. I am currently working on attachments in a parallel branch #4251 (comment) . According to the CalDAV specification, we can use our own parameters: ex So, can the avatar url parameter be passed when adding a user? In my case its look like this in .ics file: |
Signed-off-by: Thomas Citharel <[email protected]>
Closes #3099 Signed-off-by: Thomas Citharel <[email protected]>
Signed-off-by: Thomas Citharel <[email protected]>
tcitworld
force-pushed
the
bug/3099/attendees-avatars
branch
from
d676fa4
to
5662542
Compare
Works when you add new attendees, but still needs work to fetch existing ones when loading the event editor.
Also fixes useless calls to user status if attendee if not an user.
Fixes #3099