-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Release 8.4.0 #4987
chore: Release 8.4.0 #4987
Conversation
Is this the first release with full Vue 3 support? #3692 (comment) |
No, we should make |
But I forgot to mention deprecated stuff in the changelog. |
2acf786
to
bae2530
Compare
Let me know if you think we should have logical CSS properties fully added in this release, and you can wait for one more week. Otherwise, they will be added in the next release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a proposition for changing the category of #4965
* fix(NcAppSettingsDialog): respect showNavigation prop by @ShGKme in https://github.com/nextcloud-libraries/nextcloud-vue/pull/4954 | ||
* fix(NcAppNavigation): Bring back hover state for active element by @susnux in https://github.com/nextcloud-libraries/nextcloud-vue/pull/4960 | ||
* enh(aria): changed check color to adhere to 3:1 ratio by @emoral435 in https://github.com/nextcloud-libraries/nextcloud-vue/pull/4958 | ||
* Use logical style for NcHeaderMenu by @ahangarha in https://github.com/nextcloud-libraries/nextcloud-vue/pull/4965 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure if this PR should be categorized under bug fixes. I see it more as adding new capability to the UI to adjust itself to the direction of its context.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is a bug if it does not work for some languages?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd call it definitely a bug fix. The component didn't work correctly. A new feature is a new component/function or new feature of a component with a new property/event and ect.
We always can make a new library release when needed, so we can just make 8.4.1 release next week or in 2 weeks. Next Nextcloud server release is planned for 25 Jan 2024 anyway. |
But we can also wait for next year to get some more in as there will not much updating anyways |
In any case, I would like to have all the logical style fixes before the NextCloud-server release so that it can use these styles. In any case, I should hurry up 🙂 🏃🏾♂️ |
Signed-off-by: Grigorii K. Shartsev <[email protected]>
bae2530
to
14616d8
Compare
Rebased on |
v8.4.0 (2023-12-22)
Full Changelog
Notes
isMobile
andisFullscreen
mixins are now deprecated, useuseIsMobile
anduseIsFullscreen
composables instead🚀 Enhancements
aria-label
by @susnux in enh(NcCheckboxRadioSwitch): Allow to setaria-label
#4903🐛 Fixed bugs
active
prop by @raimund-schluessler in fix(NcAppNavigationItem): fix style when usingactive
prop #4989aria-expanded="false"
when menu is closed instead of removing it by @ShGKme in fix(NcActions): providearia-expanded="false"
when menu is closed instead of removing it #4946TextArea
styles withTextField
styles by @JuliaKirschenheuter in EqualizeTextArea
styles withTextField
styles #4971NcRichContenteditable
by @JuliaKirschenheuter in Increase contrast on input field forNcRichContenteditable
#4975Other Changes