enh(breadcrumbs): changed aria label for voice control on a-tag #4973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emoral435
requested review from
susnux,
JuliaKirschenheuter,
Pytal and
ShGKme
emoral435
added
3. to review
ShGKme
reviewed
Dec 19, 2023
There was a problem hiding this comment.
Setting aria-label works as a part of setting $attrs via linkAttributes. Extra aria-label is set on the server: https://github.com/nextcloud/server/blob/6fa377e90e269b1610aab2b40bba3e3ab78f0b4b/apps/files/src/components/BreadCrumbs.vue#L6
It should also be fixed on the server so incorrect aria-label is not set there.
Signed-off-by: Eduardo Morales <[email protected]>
emoral435
force-pushed
the
fix/aria-breadcrumbs-voice-control
branch
from
cd3e18b
to
48bc60f
Compare
|
Updated this PR, making a PR for the server repository as well 😃 |
ShGKme
approved these changes
Dec 19, 2023
4 tasks
susnux
approved these changes
Dec 19, 2023
ShGKme
added
bug
|
Remember to add |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves nextcloud/server#42265
🖼️ Screenshots
🚧 Tasks
Changed components aria label to better represent the content of the span for screen readers
🏁 Checklist