-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(NcAppSidebar): add focus trap on mobile #4909
Conversation
800b8bc
to
8415a2b
Compare
There is an issue with NcActions on mobile view now. But the same issue happens in See: #4910 |
8415a2b
to
c118ae3
Compare
a004cad
to
af1ba1f
Compare
8433b64
to
5e8aa01
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works, great!
do we need a focus here
nextcloud-vue/src/components/NcAppSidebar/NcAppSidebar.vue
Lines 368 to 369 in 5e8aa01
tabindex="0" | |
@click="onFigureClick" |
Yep, but it should also have a button role and have a label |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like an important improvement! 👍
Signed-off-by: Grigorii K. Shartsev <[email protected]>
Signed-off-by: Grigorii K. Shartsev <[email protected]>
Signed-off-by: Grigorii K. Shartsev <[email protected]>
5e8aa01
to
66d0264
Compare
Rebased onto master |
☑️ Resolves
On mobile view, the sidebar is full-screen. But it doesn't have a focus trap. So the focus may fall into the main content below the sidebar.
🖼️ Screenshots
🚧 Tasks
For discussion
🏁 Checklist