-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use render function in Actions component #2911
Conversation
060abf3
to
3c8d737
Compare
4f4280d
to
b5460c9
Compare
This PR is ready for a first round of reviews. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested in the docs and work, code looks good to me too. I can't test in Talk because everything is still messed up by the floating vue stuff.
@raimund-schluessler can we create a separate pr with the cypress fix and get that in asap?
What cypress fix do you mean? |
Oh nvm, I thought you fixed the snapshots that were failing on master here |
No, I just had to update the snapshots, because we use The snapshots look fine on master, though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
However, I don't know if this is wanted for the Actions component.
Consistency for similar functionality is a good thing! It looks great now (especially the keyboard a11y 💯)
@marcoambrosini Can we do a |
Signed-off-by: Raimund Schlüßler <[email protected]>
Signed-off-by: Raimund Schlüßler <[email protected]>
Signed-off-by: Raimund Schlüßler <[email protected]>
b9f80b2
to
57f6c74
Compare
@raimund-schluessler sounds good but don't we want this in v5.5.0 too? |
I wouldn't backport this. It's a quite big change, and it relies / uses changes that are only present in master / 6.0.0 e.g. the migration to floating-vue (which is breaking). |
Since #3006 removes the breaking part of #2911, it was moved to enhancements Signed-off-by: Vincent Petry <[email protected]>
This PR aims at fixing #2902. It changes the
Actions
component to use a render function instead of atemplate
and introduces theButton
vue component as popover trigger and single action button. #2902 is fixed for me when checking e.g. on the Tasks dashboard. I hope that I have correctly re-implemented all features of the Actions component, but this needs extensive testing, especially since this component is so widely used throughout Nextcloud.Since
Actions
now usesButton
, there are some visual changes to theActions
trigger, which align the appearance to theButton
component (and make the Cypress test fail for now). However, I don't know if this is wanted for theActions
component. I guess, that's a question for @jancborchardt and @nimishavijay. I don't have any before/after screenshots, because I think it's best viewed in the docs:Before: https://nextcloud-vue-components.netlify.app/#/Components/Actions?id=actions-1
After: https://deploy-preview-2911--nextcloud-vue-components.netlify.app/#/Components/Actions?id=actions-1
The only issue known to me (yet) is, that theclose-after-click
prop of e.g. theActionButton
introduced in #622 does not work in the production build, becausethis.$parent
of theActionButton
isnull
(for reasons unknown to me). With a dev build, like in the docs, it works just fine. Any hint here would be very welcome.I just noticed that this is broken on master too when using
npm link
,close-after-click
has no effect anymore. It works with6.0.0-alpha.0
installed vianpm
though. So I guess this is either an issue withnpm link
or this is a "feature"/bug of vue 2.7.8 which we bumped in #2929. I will check and create a separate issue for this if necessary.