-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump vue from 2.6.14 to 2.7.8 #2929
Conversation
vue-template-compiler needs to be bumped to the same version? |
Yes, it needs to be the same version. I bumped it as well. |
But package.json in this PR still has |
Ah, indeed. Here it's listed separately. I was used to the apps were it is required via nextcloud/webpack, so I bumped it via npm update vue-template-compiler. It could be, that vue-template-compiler is not needed for [email protected] at all anymore. I will check. |
I removed the explicit dependency to vue-template-compiler. |
The downside of removing the explicit dependency is that dependabot would then not bump those at the same time. |
0cc1f52
to
80b8e19
Compare
Ok, then let's keep it. I adjusted the vue-template-compiler version in package.json. Let's hope dependabot takes care of updating properly |
80b8e19
to
103e875
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than CI failure and conflicting package-lock.json
Signed-off-by: Raimund Schlüßler <[email protected]>
103e875
to
d29c12b
Compare
conflict resolved |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Marking as breaking as we've seen some incompatibilities when using dependencies that rely on either 2.6 or 2.7 together in text. |
This bumps vue to 2.7.8.
This fixes an issue when you use
npm link
with an app that already uses[email protected]
(e.g. Tasks). Linking then fails with an obscure "vm._scope is undefined" error. Bumping vue here as well makes it work again. Installing nextcloud/vue via npm works in any case.