Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump vue from 2.6.14 to 2.7.8 #2929

Merged
merged 1 commit into from
Aug 4, 2022
Merged

Conversation

raimund-schluessler
Copy link
Contributor

@raimund-schluessler raimund-schluessler commented Aug 3, 2022

This bumps vue to 2.7.8.

This fixes an issue when you use npm link with an app that already uses [email protected] (e.g. Tasks). Linking then fails with an obscure "vm._scope is undefined" error. Bumping vue here as well makes it work again. Installing nextcloud/vue via npm works in any case.

@raimund-schluessler raimund-schluessler added bug Something isn't working 3. to review Waiting for reviews dependencies Pull requests that update a dependency file technical debt labels Aug 3, 2022
@raimund-schluessler raimund-schluessler added this to the 6.0.0 milestone Aug 3, 2022
@nickvergessen
Copy link
Contributor

vue-template-compiler needs to be bumped to the same version?
At least I got errors in some repos otherwise

@raimund-schluessler
Copy link
Contributor Author

vue-template-compiler needs to be bumped to the same version?

At least I got errors in some repos otherwise

Yes, it needs to be the same version. I bumped it as well.

@nickvergessen
Copy link
Contributor

But package.json in this PR still has "vue-template-compiler": "^2.6.14",

@raimund-schluessler
Copy link
Contributor Author

But package.json in this PR still has "vue-template-compiler": "^2.6.14",

Ah, indeed. Here it's listed separately. I was used to the apps were it is required via nextcloud/webpack, so I bumped it via npm update vue-template-compiler.

It could be, that vue-template-compiler is not needed for [email protected] at all anymore. I will check.

@raimund-schluessler
Copy link
Contributor Author

But package.json in this PR still has "vue-template-compiler": "^2.6.14",

I removed the explicit dependency to vue-template-compiler.

@juliusknorr
Copy link
Contributor

The downside of removing the explicit dependency is that dependabot would then not bump those at the same time.

@raimund-schluessler
Copy link
Contributor Author

The downside of removing the explicit dependency is that dependabot would then not bump those at the same time.

Ok, then let's keep it. I adjusted the vue-template-compiler version in package.json. Let's hope dependabot takes care of updating properly

Copy link
Contributor

@Pytal Pytal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than CI failure and conflicting package-lock.json

Signed-off-by: Raimund Schlüßler <[email protected]>
@PVince81 PVince81 force-pushed the dependaray/npm_and_yarn/vue-2.7.8 branch from 103e875 to d29c12b Compare August 4, 2022 20:31
@PVince81
Copy link
Contributor

PVince81 commented Aug 4, 2022

conflict resolved

@PVince81 PVince81 added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Aug 4, 2022
Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 merged commit bcaf707 into master Aug 4, 2022
@PVince81 PVince81 deleted the dependaray/npm_and_yarn/vue-2.7.8 branch August 4, 2022 20:38
@juliusknorr juliusknorr added the breaking PR that requires a new major version label Aug 4, 2022
@juliusknorr
Copy link
Contributor

Marking as breaking as we've seen some incompatibilities when using dependencies that rely on either 2.6 or 2.7 together in text.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish breaking PR that requires a new major version bug Something isn't working dependencies Pull requests that update a dependency file technical debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants