New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Focusing last action in `Actions` component with page-down is broken #2958

Closed

raimund-schluessler opened this issue Aug 5, 2022 · 0 comments · Fixed by #2911 or #2961

Labels

bug feature: actions

Milestone

Contributor

raimund-schluessler commented Aug 5, 2022

This line
https://github.com/nextcloud/nextcloud-vue/blob/5392fd1a9d8f34f137654227010f30876cd31d3d/src/components/Actions/Actions.vue#L849
should read

this.focusIndex = this.$refs.menu.querySelectorAll(focusableSelector).length - 1

raimund-schluessler added bug feature: actions labels

raimund-schluessler added this to the 5.4.1 milestone

raimund-schluessler linked a pull request

that will close this issue

Use render function in Actions component #2911

Merged

raimund-schluessler mentioned this issue

Fix focusing last action with page-down #2961

Merged

marcoambrosini closed this as completed in #2961

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment