Feature/noid/avatar menu use actions component #1670
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marco Ambrosini <[email protected]>
Use the correct variable for iterating over the menu items Signed-off-by: Vincent Petry <[email protected]>
Fix avatar popover trigger placement and alignment. Fix icon size in menu item to be 16px instead of 44px. Signed-off-by: Vincent Petry <[email protected]>
VPopover is always visible even when "open" is false. This fix makes it hidden visually off screen instead. Solves issues with flying arrows when opening and closing some action menus. Signed-off-by: Vincent Petry <[email protected]>
Signed-off-by: Vincent Petry <[email protected]>
Whenever the popover is set to "open" first, if the contents hasn't already been populated in the current tick, the popover's position will appear in the wrong location. Then, directly in the next tick its position is corrected based on the newly appeared content. To avoid the visual glitch we first keep it with "visibility: hidden" upon opening, and then display it once its position has been calculated. Signed-off-by: Vincent Petry <[email protected]>
When initially hiding the popover during size / position calculation, we need to override the popover's initial visibility and position to avoid glitches like scrollbars appearing. Once the correct position has been calculated by v-tooltip/popper, we can remove the strong hiding class. Signed-off-by: Vincent Petry <[email protected]>
Signed-off-by: Vincent Petry <[email protected]>
This was referenced Jan 19, 2021
|
I think this is the wrong way. Instead one of the next todos is to blow the menu up and show a bigger avatar similar to what github does: |
|
Right, and we still need a place for the actions. Maybe a sub-menu inside that dialog, which itself will be the Actions menu. Was there an existing discussion somewhere already about this new design ? |
|
What is the plan here? The Avatar component is the last one to use the deprecated PopoverMenu component and I think it would be good to migrate away from it. |
|
Superseded by #4017. |
raimund-schluessler
deleted the
feature/noid/avatar-menu-use-actions-component
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the Avatar component use the Actions component for its menu.
Issues: