-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/noid/avatar menu use actions component #1670
Commits on Jan 18, 2021
-
Use the popover component for the avatar menu
Signed-off-by: Marco Ambrosini <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 3707276 - Browse repository at this point
Copy the full SHA 3707276View commit details -
Use the correct variable for iterating over the menu items Signed-off-by: Vincent Petry <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 112e846 - Browse repository at this point
Copy the full SHA 112e846View commit details -
Fix avatar popover placement and icons
Fix avatar popover trigger placement and alignment. Fix icon size in menu item to be 16px instead of 44px. Signed-off-by: Vincent Petry <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for d5b279e - Browse repository at this point
Copy the full SHA d5b279eView commit details -
Fix arrow animation of popover
VPopover is always visible even when "open" is false. This fix makes it hidden visually off screen instead. Solves issues with flying arrows when opening and closing some action menus. Signed-off-by: Vincent Petry <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for b0ab67e - Browse repository at this point
Copy the full SHA b0ab67eView commit details -
Adjust avatar menu display conditions
Signed-off-by: Vincent Petry <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 1135ba0 - Browse repository at this point
Copy the full SHA 1135ba0View commit details
Commits on Jan 19, 2021
-
Delay Popover display to avoid positioning glitches
Whenever the popover is set to "open" first, if the contents hasn't already been populated in the current tick, the popover's position will appear in the wrong location. Then, directly in the next tick its position is corrected based on the newly appeared content. To avoid the visual glitch we first keep it with "visibility: hidden" upon opening, and then display it once its position has been calculated. Signed-off-by: Vincent Petry <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 93edc79 - Browse repository at this point
Copy the full SHA 93edc79View commit details -
Added strong hiding rules for Popover
When initially hiding the popover during size / position calculation, we need to override the popover's initial visibility and position to avoid glitches like scrollbars appearing. Once the correct position has been calculated by v-tooltip/popper, we can remove the strong hiding class. Signed-off-by: Vincent Petry <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 768eed4 - Browse repository at this point
Copy the full SHA 768eed4View commit details -
Use actions component for avatar menu
Signed-off-by: Vincent Petry <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 4ecc37d - Browse repository at this point
Copy the full SHA 4ecc37dView commit details