Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump @nextcloud-vue to 3.5.1 #4976

Merged
merged 2 commits into from
Jan 21, 2021
Merged

Conversation

PVince81
Copy link
Member

Brings in the updated Avatar component which now uses Popover.

Fixes issue with dropdown menu overlap with other avatars in the
messages list.

Fixes #4147

Brings in the updated Avatar component which now uses Popover.

Fixes issue with dropdown menu overlap with other avatars in the
messages list.

Signed-off-by: Vincent Petry <[email protected]>
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Regressions: Icons are not inverted any longer on dark mode
  • Instead of scrolling the popover now just overlaps the avatar. I think elipsis would be better

Bildschirmfoto von 2021-01-20 10-45-02

@nickvergessen
Copy link
Member

Regressions: Icons are not inverted any longer on dark mode

I guess this needs fixing in server, as https://github.com/nextcloud/server/blob/f04b182b9447231b32cd5b5f8060314dee4fd801/apps/accessibility/css/dark.scss#L63 no longer matches.

@PVince81
Copy link
Member Author

Regressions: Icons are not inverted any longer on dark mode

Seems the difference with the other popover menus is that in the popover menus we use "icon-x" classes for icons, but for this actions menu it's image URLs directly.

@PVince81
Copy link
Member Author

PVince81 commented Jan 20, 2021

Regressions: Icons are not inverted any longer on dark mode

I guess this needs fixing in server, as https://github.com/nextcloud/server/blob/f04b182b9447231b32cd5b5f8060314dee4fd801/apps/accessibility/css/dark.scss#L63 no longer matches.

Dark mode fixes here:

@PVince81
Copy link
Member Author

Instead of scrolling the popover now just overlaps the avatar. I think elipsis would be better

Ellipsis means we'd need a tooltip also to be able to display the full row as there might be words behind the name like "sprechen" in German.

I looked at the actions menu and apparently it wraps there with a fixed max width, so we could do the same here:
image

Eventually once we switch to actions menu for avatars (see nextcloud-libraries/nextcloud-vue#1670) this will be in place as well implicitly.

For now I'll manually adjust these to the avatar's popover menu.

@PVince81
Copy link
Member Author

PVince81 commented Jan 20, 2021

Signed-off-by: Vincent Petry <[email protected]>
@PVince81 PVince81 changed the title Bump @nextcloud-vue to 3.5.0 Bump @nextcloud-vue to 3.5.1 Jan 20, 2021
@PVince81
Copy link
Member Author

bumped to 3.5.1 now

@PVince81
Copy link
Member Author

all merged, I've retested this PR and it works.

@PVince81 PVince81 dismissed nickvergessen’s stale review January 21, 2021 08:45

Changes have been made to fix the issue

@PVince81 PVince81 merged commit e1ff2b7 into master Jan 21, 2021
@PVince81 PVince81 deleted the deps/noid/upgrade-nextcloud-vue-3.5.0 branch January 21, 2021 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avatars and images are above avatar menu
3 participants