-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump @nextcloud-vue to 3.5.1 #4976
Conversation
Brings in the updated Avatar component which now uses Popover. Fixes issue with dropdown menu overlap with other avatars in the messages list. Signed-off-by: Vincent Petry <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this needs fixing in server, as https://github.com/nextcloud/server/blob/f04b182b9447231b32cd5b5f8060314dee4fd801/apps/accessibility/css/dark.scss#L63 no longer matches. |
Seems the difference with the other popover menus is that in the popover menus we use "icon-x" classes for icons, but for this actions menu it's image URLs directly. |
Dark mode fixes here:
|
Ellipsis means we'd need a tooltip also to be able to display the full row as there might be words behind the name like "sprechen" in German. I looked at the actions menu and apparently it wraps there with a fixed max width, so we could do the same here: Eventually once we switch to actions menu for avatars (see nextcloud-libraries/nextcloud-vue#1670) this will be in place as well implicitly. For now I'll manually adjust these to the avatar's popover menu. |
|
Signed-off-by: Vincent Petry <[email protected]>
bumped to 3.5.1 now |
all merged, I've retested this PR and it works. |
Changes have been made to fix the issue
Brings in the updated Avatar component which now uses Popover.
Fixes issue with dropdown menu overlap with other avatars in the
messages list.
Fixes #4147