feat: port status ConfigMap name setting to v1.18 #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trutx
requested review from
h0tbird,
danielpanzella,
a user,
dennisme,
dthorsen,
mytunguyen and
nicoleyson
dennisme
approved these changes
Jul 6, 2021
trutx
changed the base branch from
cluster-autoscaler-release-1.18
to
cluster-autoscaler-release-1.18-nr1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Porting kubernetes#3888 and kubernetes#3630 into
v1.18.3so two cluster autoscaler instances running in the same namespace don't collide using the same ConfigMap and the same leader election resource lock name.Additionally porting kubernetes#3940 for a cleaner leader election lock release.
Basically the same as #1 but for
v1.18.3