Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ability to set the status configMap name #1

Merged

Conversation

trutx
Copy link

@trutx trutx commented Mar 16, 2021

This ports kubernetes#3888 into the v1.17.4 release

Also porting kubernetes#3630 so two cluster-autoscaler instances don't collide in leader election context.

@trutx trutx requested review from idleyoungman, a user, dennisme and dthorsen March 16, 2021 09:16
@trutx
Copy link
Author

trutx commented Mar 16, 2021

Also porting this PR kubernetes#3940 to avoid what's below to happen on redeploys/pod restarts:

I0316 11:59:20.270592       1 main.go:371] Cluster Autoscaler 1.17.4
I0316 11:59:20.319842       1 leaderelection.go:242] attempting to acquire leader lease  kube-system/cluster-autoscaler...
I0316 11:59:20.325219       1 leaderelection.go:352] lock is held by cluster-autoscaler-7655f578d-6x9b2 and has not yet expired
I0316 11:59:20.325239       1 leaderelection.go:247] failed to acquire lease kube-system/cluster-autoscaler
I0316 11:59:23.781962       1 leaderelection.go:352] lock is held by cluster-autoscaler-7655f578d-6x9b2 and has not yet expired
I0316 11:59:23.781977       1 leaderelection.go:247] failed to acquire lease kube-system/cluster-autoscaler
I0316 11:59:28.044788       1 leaderelection.go:352] lock is held by cluster-autoscaler-7655f578d-6x9b2 and has not yet expired
I0316 11:59:28.044803       1 leaderelection.go:247] failed to acquire lease kube-system/cluster-autoscaler
I0316 11:59:31.645043       1 leaderelection.go:352] lock is held by cluster-autoscaler-7655f578d-6x9b2 and has not yet expired
I0316 11:59:31.645059       1 leaderelection.go:247] failed to acquire lease kube-system/cluster-autoscaler
I0316 11:59:34.700998       1 leaderelection.go:352] lock is held by cluster-autoscaler-7655f578d-6x9b2 and has not yet expired
I0316 11:59:34.701012       1 leaderelection.go:247] failed to acquire lease kube-system/cluster-autoscaler
I0316 11:59:37.742850       1 leaderelection.go:252] successfully acquired lease kube-system/cluster-autoscaler

@idleyoungman
Copy link

Minor nit, doesn't need to block moving ahead: looks like the const for StatusConfigMapName is still there in cluster-autoscaler/clusterstate/utils/status.go but was removed in the upstream PR

Copy link

@idleyoungman idleyoungman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM w/ the note about the unused const.

@trutx
Copy link
Author

trutx commented Mar 16, 2021

Good catch @idleyoungman, totally missed that one. Fixed.

@idleyoungman idleyoungman self-requested a review March 17, 2021 00:22
@trutx trutx merged commit c2f7286 into cluster-autoscaler-release-1.17 Mar 17, 2021
@trutx trutx deleted the rtorrents/cluster-autoscaler-1.17.4-nr1 branch March 17, 2021 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants