forked from kubernetes/autoscaler
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ability to set the status configMap name #1
Merged
trutx
merged 4 commits into
cluster-autoscaler-release-1.17
from
rtorrents/cluster-autoscaler-1.17.4-nr1
Mar 17, 2021
Merged
feat: ability to set the status configMap name #1
trutx
merged 4 commits into
cluster-autoscaler-release-1.17
from
rtorrents/cluster-autoscaler-1.17.4-nr1
Mar 17, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also porting this PR kubernetes#3940 to avoid what's below to happen on redeploys/pod restarts:
|
idleyoungman
approved these changes
Mar 16, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM w/ the note about the unused const.
Good catch @idleyoungman, totally missed that one. Fixed. |
idleyoungman
approved these changes
Mar 17, 2021
This was referenced Jul 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ports kubernetes#3888 into the
v1.17.4
releaseAlso porting kubernetes#3630 so two cluster-autoscaler instances don't collide in leader election context.