Allow name of cluster-autoscaler status ConfigMap to be specificed

[mrak]

Adds --status-config-map-name, which defaults to the original value of cluster-autoscaler-status.

This allows us to run two instances of cluster-autoscaler in our cluster, targeting two different types of autoscaling groups that require different command-line settings to be passed.

Do you foresee this causing any issues with the cluster-wide portion of the configmap status?

[k8s-ci-robot]

Welcome @mrak!

It looks like this is your first PR to kubernetes/autoscaler 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/autoscaler has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[mrak]

/assign @feiskyer

[elmiko]

this seems reasonable to me, i think it would be worthwhile to update the parameter list in the faq as well.

Do you foresee this causing any issues with the cluster-wide portion of the configmap status?

looking around the code, i don't think this change will negatively impact the configmap status. but i'm not sure i get what you mean by "cluster-wide portion". iiuc each autoscaler will write its own status to the configmap, which sounds like what you want for your topology.

[mrak]

I'll see about updating the FAQ.

I meant the Cluster-wide portion like it appears here in the status ConfigMap:

Cluster-autoscaler status at 2021-03-03 15:38:29.243693431 +0000 UTC:
Cluster-wide:
  Health:      Healthy (ready=12 unready=0 notStarted=0 longNotStarted=0 registered=12 longUnregistered=0)
               LastProbeTime:      2021-03-03 15:38:29.240488873 +0000 UTC m=+52443.391263853
               LastTransitionTime: 2021-03-03 01:05:02.436510487 +0000 UTC m=+36.587285469
  ScaleUp:     NoActivity (ready=12 registered=12)
               LastProbeTime:      2021-03-03 15:38:29.240488873 +0000 UTC m=+52443.391263853
               LastTransitionTime: 2021-03-03 01:05:02.436510487 +0000 UTC m=+36.587285469
  ScaleDown:   NoCandidates (candidates=0)
               LastProbeTime:      2021-03-03 15:38:29.240488873 +0000 UTC m=+52443.391263853
               LastTransitionTime: 2021-03-03 01:36:27.848962781 +0000 UTC m=+1921.999737689

NodeGroups:
  Name:        asg-name-us-east-2a
  Health:      Healthy (ready=2 unready=0 notStarted=0 longNotStarted=0 registered=2 longUnregistered=0 cloudProviderTarget=2 (minSize=2, maxSize=5))
               LastProbeTime:      2021-03-03 15:38:29.240488873 +0000 UTC m=+52443.391263853
               LastTransitionTime: 2021-03-03 01:05:02.436510487 +0000 UTC m=+36.587285469
  ScaleUp:     NoActivity (ready=2 cloudProviderTarget=2)
               LastProbeTime:      2021-03-03 15:38:29.240488873 +0000 UTC m=+52443.391263853
               LastTransitionTime: 2021-03-03 01:05:02.436510487 +0000 UTC m=+36.587285469
  ScaleDown:   NoCandidates (candidates=0)
               LastProbeTime:      2021-03-03 15:38:29.240488873 +0000 UTC m=+52443.391263853
               LastTransitionTime: 2021-03-03 01:16:23.041505368 +0000 UTC m=+717.192280277

[elmiko]

this seems reasonable to me
/lgtm

[mrak]

/assign @feiskyer

[mwielgus]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elmiko, mrak, mwielgus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• cluster-autoscaler/OWNERS [mwielgus]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment