Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dao NTRN-206 #8

Merged
merged 36 commits into from
Dec 14, 2022
Merged

feat: dao NTRN-206 #8

merged 36 commits into from
Dec 14, 2022

Conversation

quasisamurai
Copy link
Contributor

@quasisamurai quasisamurai commented Nov 26, 2022

This pr implements neutron version of DAO, based on DA0-DA0. It comes in pair w this PR.

Key concepts:
4 contracts:

  • core contract, which manages all stuff
  • voting vault contract, which allows user to bond his money, in return, getting the opportunity to create proposals and vote (first in pre-propose, voting in proposal contract)
  • voting registry contract, which is bonded to core contract, so it calculates voting power potentially from various sources (e.g. liquidity pool, vault contracts etc.). currently it is works only w staking contract due this version is kinda first one. this is our conceptual innovation non-existing in dao-dao
  • proposal contract, which has an interface to create proposals (only pre-propose module can do this) vote on them, and ofc - execute them
  • pre-propose which has privileged rights is used to submit proposals, also it manages proposal deposits

related tasks:

How to test:

  1. branch from this PR | make init
  2. sh test_proposal.sh

@quasisamurai quasisamurai changed the title feat: dao feat: dao NTRN-206 Nov 28, 2022
@zavgorodnii
Copy link
Contributor

i have an error after running this script:

list archived proposals
test_proposal.sh: line 170: unexpected EOF while looking for matching `"'
test_proposal.sh: line 173: syntax error: unexpected end of file

@quasisamurai quasisamurai marked this pull request as ready for review December 13, 2022 11:57
zavgorodnii
zavgorodnii previously approved these changes Dec 14, 2022
Copy link
Contributor

@zavgorodnii zavgorodnii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@zavgorodnii zavgorodnii dismissed their stale review December 14, 2022 12:58

security issues

zavgorodnii
zavgorodnii previously approved these changes Dec 14, 2022
@zavgorodnii zavgorodnii merged commit 2cec0c7 into main Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants