feat: dao based governance NTRN-206 #53
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quasisamurai
changed the title
quasisamurai
force-pushed
the
feat/alternative-goverance
branch
from
f51ac8b
to
b633408
Compare
quasisamurai
force-pushed
the
feat/alternative-goverance
branch
2 times, most recently
from
928d8ef
to
bd94cd7
Compare
quasisamurai
force-pushed
the
feat/alternative-goverance
branch
from
94a2228
to
2da5a15
Compare
zavgorodnii
reviewed
Oct 7, 2022
proto/adminmodule/genesis.proto
Outdated
|
|
||
| import "gogoproto/gogo.proto"; | ||
|
|
||
| // this line is used by starport scaffolding # genesis/proto/import |
zavgorodnii
reviewed
Oct 7, 2022
proto/adminmodule/query.proto
Outdated
|
|
||
| // Query defines the gRPC querier service. | ||
| service Query { | ||
| // this line is used by starport scaffolding # 2 |
There was a problem hiding this comment.
all these likes should be removed i think
zavgorodnii
reviewed
Oct 7, 2022
wasmbinding/bindings/msg.go
Outdated
| @@ -17,6 +19,8 @@ type NeutronMsg struct { | |||
| RegisterInterchainQuery *RegisterInterchainQuery `json:"register_interchain_query,omitempty"` | |||
| UpdateInterchainQuery *UpdateInterchainQuery `json:"update_interchain_query,omitempty"` | |||
| RemoveInterchainQuery *RemoveInterchainQuery `json:"remove_interchain_query,omitempty"` | |||
| AddAdmin *AddAdmin `json:"add_admin,omitempty"` | |||
There was a problem hiding this comment.
why exactly do we need an add admin message available for the contracts? aren't we going to add a single admin to genesis?
There was a problem hiding this comment.
That was a very first method i implemented, so i have not removed AddAdmin exactly to leave a space to discussion - "are we need this one?".
zavgorodnii
reviewed
Oct 7, 2022
| cont, err := proto.Marshal(&prop) | ||
| if err != nil { | ||
| return nil, sdkerrors.Wrap(err, "failed to marshall incoming SubmitProposal message") | ||
| } |
There was a problem hiding this comment.
here and everywhere: please add newlines after error checks
zavgorodnii
reviewed
Oct 7, 2022
wasmbinding/message_plugin.go
Outdated
| msg := admintypes.MsgSubmitProposal{Proposer: contractAddr.String()} | ||
|
|
||
| if submitProposal.Proposals.TextProposal != nil { | ||
|
|
zavgorodnii
reviewed
Oct 7, 2022
wasmbinding/message_plugin.go
Outdated
| func (m *CustomMessenger) addAmin(ctx sdk.Context, contractAddr sdk.AccAddress, addAdmin *bindings.AddAdmin) ([]sdk.Event, [][]byte, error) { | ||
| response, err := m.PerformAddAmin(ctx, contractAddr, addAdmin) | ||
| if err != nil { | ||
| ctx.Logger().Debug("PerformSubmitTx: failed to addAdmin", |
There was a problem hiding this comment.
PerformSubmitTx is a copy-and-paste
zavgorodnii
reviewed
Oct 7, 2022
| wasmQueryPlugin := NewQueryPlugin(ictxKeeper, icqKeeper) | ||
|
|
||
| queryPluginOpt := wasmkeeper.WithQueryPlugins(&wasmkeeper.QueryPlugins{ | ||
| Custom: CustomQuerier(wasmQueryPlugin), | ||
| }) | ||
| messagePluginOpt := wasmkeeper.WithMessageHandlerDecorator( | ||
| CustomMessageDecorator(ictxKeeper, icqKeeper), | ||
| CustomMessageDecorator(ictxKeeper, icqKeeper, admKeeper), |
There was a problem hiding this comment.
maybe give this variable a full name? adminKeeper? not sure we gain anything from losing a couple of characters. also in other places it has a full name
zavgorodnii
reviewed
Oct 7, 2022
| "result", logMsg, | ||
| ) | ||
|
|
||
| // TODO event? |
zavgorodnii
reviewed
Oct 7, 2022
x/adminmodule/client/cli/query.go
Outdated
| "github.com/spf13/cobra" | ||
|
|
||
| "github.com/cosmos/cosmos-sdk/client" | ||
| // "github.com/cosmos/cosmos-sdk/client/flags" |
zavgorodnii
reviewed
Oct 7, 2022
| return m, nil | ||
| } | ||
|
|
||
| //func (m *MsgSubmitProposal) GetContent() govtypes.Content { // TODO m.Content.GetCachedValue() returns nil! |
zavgorodnii
reviewed
Oct 7, 2022
x/adminmodule/module.go
Outdated
| } | ||
|
|
||
| func (am AppModule) DefaultGenesis(jsonCodec codec.JSONCodec) json.RawMessage { | ||
| //TODO implement me |
zavgorodnii
reviewed
Oct 7, 2022
x/adminmodule/module.go
Outdated
| } | ||
|
|
||
| func (am AppModule) ValidateGenesis(jsonCodec codec.JSONCodec, config client.TxEncodingConfig, message json.RawMessage) error { | ||
| //TODO implement me |
zavgorodnii
reviewed
Oct 7, 2022
| ) | ||
|
|
||
| // NewQuerier creates a new adminmodule Querier instance | ||
| func NewQuerier(keeper Keeper, legacyQuerierCdc *codec.LegacyAmino) sdk.Querier { |
There was a problem hiding this comment.
i don't think this is the way to go in sdk 0.45; please check the query implementations in our modules
pr0n00gler
requested changes
Oct 10, 2022
wasmbinding/message_plugin.go
Outdated
| Title: submitProposal.Proposals.TextProposal.Title, | ||
| Description: submitProposal.Proposals.TextProposal.Description, | ||
| } | ||
| var parameterChanges []paramChange.ParamChange |
There was a problem hiding this comment.
parameterChanges := make([]paramChange.ParamChange, 0, len(proposal.Changes))
wasmbinding/message_plugin.go
Outdated
| Description: submitProposal.Proposals.TextProposal.Description, | ||
| } | ||
| var parameterChanges []paramChange.ParamChange | ||
| for _, parameterChange := range proposal.Changes { |
There was a problem hiding this comment.
What about making proposal.Changes in bindings.SubmitProposal as paramChange.ParamChange type?
You don't need this loop then.
foxpy
requested changes
Oct 12, 2022
|
NOTE FOR EVERYONE: WE DO NOT NEED TO FIX MODULE FORMATTING, ETC.; WE'LL USE INFORMAL ADMIN MODULE LATER ON. |
foxpy
requested changes
Oct 24, 2022
quasisamurai
force-pushed
the
feat/alternative-goverance
branch
from
4309d30
to
83a1772
Compare
quasisamurai
changed the base branch from
main
to
neutron_audit_oak_19_09_2022_fixes
quasisamurai
changed the title
quasisamurai
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task 1
Task 2
This PR implements a neutron's vision of governance. It uses admin module in bound with smart contract bindings, provided w this pr.
testing:
make init./test_proposal.sh