DAO refactoring: bring submit proposal to neutron msg #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ratik
reviewed
Dec 8, 2022
| /// * **proposal** is struct which contains proposal that should change network parameter | ||
| pub fn submit_param_change_proposal(proposal: ParamChangeProposal) -> Self { | ||
| NeutronMsg::SubmitProposal { | ||
| proposals: Proposals { |
There was a problem hiding this comment.
mb it's Proposal and not Proposals?
zavgorodnii
reviewed
Dec 8, 2022
| @@ -110,6 +110,8 @@ pub enum NeutronMsg { | |||
| timeout_timestamp: u64, | |||
| fee: IbcFee, | |||
| }, | |||
| /// SubmitProposal sends a proposal to neutron's Admin module | |||
There was a problem hiding this comment.
- Rename to SubmitAdminProposal
- Write a comment that explicitly states that this type of messages can only be executed by the Neutron DAO
zavgorodnii
reviewed
Dec 8, 2022
| #[derive(Serialize, Deserialize, Clone, Debug, PartialEq, Eq, JsonSchema)] | ||
| #[serde(rename_all = "snake_case")] | ||
| /// Proposals defines the struct for various proposals which neutron may accept (currently only parameter change) | ||
| pub struct Proposals { |
There was a problem hiding this comment.
- Rename to AdminProposal
- Add a comment that currently only param change proposals are implemented, but new types of admin proposals might be implemented in the future
zavgorodnii
reviewed
Dec 8, 2022
| @@ -110,6 +110,9 @@ pub enum NeutronMsg { | |||
| timeout_timestamp: u64, | |||
| fee: IbcFee, | |||
| }, | |||
| /// SubmitAdminProposal sends a proposal to neutron's Admin module. | |||
| /// This type of messages can be only executed by Neutron DAO. | |||
| SubmitProposal { admin_proposal: AdminProposal }, | |||
There was a problem hiding this comment.
Please rename to SubmitAdminProposal.
zavgorodnii
previously approved these changes
Dec 9, 2022
ratik
previously approved these changes
Dec 9, 2022
sotnikov-s
requested changes
Dec 9, 2022
swelf19
reviewed
Dec 9, 2022
| @@ -110,6 +110,9 @@ pub enum NeutronMsg { | |||
| timeout_timestamp: u64, | |||
| fee: IbcFee, | |||
| }, | |||
| /// SubmitAdminProposal sends a proposal to neutron's Admin module. | |||
| /// This type of messages can be only executed by Neutron DAO. | |||
| SubmitAdminProposal { admin_proposal: AdminProposal }, | |||
There was a problem hiding this comment.
I think it could be a good idea to hide the variant by some feature flag, lets say "dao", and hide other admin/dao specific types and functions as well
There was a problem hiding this comment.
that's an interesting but not really useful idea. I'd discuss whether we really need it and, if yes, made it as a separate task
sotnikov-s
approved these changes
Dec 9, 2022
zavgorodnii
approved these changes
Dec 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required by this PR