-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dev): document how to disable browser auto launch #4106
Conversation
src/commands/dev/dev.js
Outdated
'netlify dev', | ||
'netlify dev -d public', | ||
'netlify dev -c "hugo server -w" --targetPort 1313', | ||
'BROWSER=firefox netlify dev # auto open firefox instead of preferred browser', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This bit should work (setting to firefox), but currently doesn't due to an upstream bug:
michaellzc/better-opn#38
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh wow, the only thing I didn't try.. my bad, I'll change it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right, better to remove it for now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requested changes until the removal of BROWSER=firefox
🎉 Thanks for submitting a pull request! 🎉
Summary
Fixes #4100
Document how to avoid the browser being auto opened when using
netlify dev
.Feel free to suggest better text or anything
Screenshots of the modified docs
For us to review and ship your PR efficiently, please perform the following steps:
passes our tests.
A picture of a cute animal (not mandatory, but encouraged)
he ⬇ wrote the docs so if there are errors it's not my fault