Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to turn off autoLaunch in dev command #4100

Closed
albertodeago opened this issue Jan 21, 2022 · 4 comments · Fixed by #4106
Closed

Add an option to turn off autoLaunch in dev command #4100

albertodeago opened this issue Jan 21, 2022 · 4 comments · Fixed by #4106
Labels
area: command: dev type: feature code contributing to the implementation of a feature and/or user facing functionality

Comments

@albertodeago
Copy link
Contributor

Is your feature request related to a problem? Please describe.

I really would like to have an option to be able to turn off the autoLaunch behaviour of the dev command.
I understand why by default it's turned on, but I think that it would be a nice addition to add a way to turn it off if needed.

Describe the solution you'd like

I would like to add (I can already open a PR if accepted) an option called --autoLaunch on the dev command. By default it would be true so that there would be no breaking change, but if provided a false value, the browser won't be auto opened.

Describe alternatives you've considered

I know that this can already be done via toml file, but I think it would be a nice addition to the CLI itself

Can you submit a pull request?

Yes.

@albertodeago albertodeago added the type: feature code contributing to the implementation of a feature and/or user facing functionality label Jan 21, 2022
@erezrokah
Copy link
Contributor

Hi @albertodeago! Thank you for opening the issue. This is available via BROWSER=none ntl dev, due to the underlying library we use to open the browser.

We can probably document it better, so maybe adding it under https://cli.netlify.com/commands/dev or https://cli.netlify.com/netlify-dev#usage (or both) will make it more visible.

@albertodeago
Copy link
Contributor Author

thanks @erezrokah for the quick response.
Oh wow I didn't find this info anywhere so I think it would be a nice addition in the docs, do you want me to submit a pr on the dev docs?

@erezrokah
Copy link
Contributor

A PR would be very helpful, thanks @albertodeago!

@albertodeago
Copy link
Contributor Author

I'll do that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: command: dev type: feature code contributing to the implementation of a feature and/or user facing functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants