fix: pass app object to open instead of string/array #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
michaellzc
approved these changes
Jan 21, 2022
|
hey @erezrokah thanks a lot for the fix. a new patch has been released https://www.npmjs.com/package/better-opn/v/3.0.2 |
|
Thank you for the quick review and release! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello 👋
Thank you for this package ❤️
It seems 5a185c2 broke the
openinvocation as it didn't update the structure of the arguments per https://github.com/sindresorhus/open/releases/tag/v8.0.0.You can try this by writing a script that uses this library and set
BROWSER=firefoxto see.This PR fixes the above issue.