Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pass app object to open instead of string/array #38

Merged
merged 1 commit into from
Jan 21, 2022
Merged

fix: pass app object to open instead of string/array #38

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,14 +98,13 @@ const startBrowserProcess = (browser, url, opts = {}, args = []) => {
browser = undefined;
}

// If there are arguments, they must be passed as array with the browser
if (typeof browser === 'string' && args.length > 0) {
browser = [browser].concat(args);
}

// Fallback to opn
// (It will always open new tab)
const options = {app: browser, url: true, wait: false, ...opts};
const options = {
app: {name: browser, arguments: args},
wait: false,
...opts,
};
return require('open')(url, options);
};

Expand Down