Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for aliasing connection multiple times #403

Merged
merged 3 commits into from
Aug 10, 2021

Conversation

dmoree
Copy link
Contributor

@dmoree dmoree commented Aug 9, 2021

Description

Similar to #359, this adds the ability to have multiple aliases on connection fields without overwriting parameters by naming parameters after aliases and fields after names.

Issue

Checklist

  • Documentation has been updated
  • TCK tests have been updated
  • Integration tests have been updated
  • Example applications have been updated
  • New files have copyright header
  • CLA (https://neo4j.com/developer/cla/) has been signed

Copy link
Contributor

@darrellwarde darrellwarde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, really well tested! Thanks for taking another look following our previous review - just in time for release. 🙂

@darrellwarde darrellwarde merged commit 5f2300b into neo4j:2.0.0 Aug 10, 2021
@dmoree dmoree deleted the bugfix/connection-multiple-alias branch August 10, 2021 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Attributes get lost when calling a connection multiple times using aliases
3 participants