Attributes get lost when calling a connection multiple times using aliases

[dmoree]

Describe the bug
Similar to #350 the parameters passed do not correspond to the aliased fields leaving aliasing broken when using a connection field multiple times.

Type definitions
Based on the neo-push schema with an added boolean flag on Comment

To Reproduce

1. Clone repository Deleted
2. Seed and start server Deleted
3. Run each query in GraphiQL at http://localhost:4000/graphql (or as defined in .env)

Flagged

query PostsWithFlaggedComments {
  posts {
    commentsConnection(where: { node: { flag: true } }) {
      edges {
        node {
          id
          flag
        }
      }
    }
  }
}

{
  "data": {
    "posts": [
      {
        "commentsConnection": {
          "edges": [
            {
              "node": {
                "id": "91971f9b-142f-491a-9373-fe282631848b",
                "flag": true
              }
            },
            {
              "node": {
                "id": "2fe20b67-1b40-4946-bc80-f6789057b4ee",
                "flag": true
              }
            }
          ]
        }
      }
    ]
  }
}

Unflagged

query PostsWithUnflaggedComments {
  posts {
    commentsConnection(where: { node: { flag: false } }) {
      edges {
        node {
          id
          flag
        }
      }
    }
  }
}

{
  "data": {
    "posts": [
      {
        "commentsConnection": {
          "edges": [
            {
              "node": {
                "id": "59036026-39e0-4761-99ab-9ed8ad369e0b",
                "flag": false
              }
            }
          ]
        }
      }
    ]
  }
}

Both

flagged last

query PostsWithUnflaggedAndFlaggedComments {
  posts {
    unflagged: commentsConnection(where: { node: { flag: false } }) {
      edges {
        node {
          id
          flag
        }
      }
    }
    flagged: commentsConnection(where: { node: { flag: true } }) {
      edges {
        node {
          id
          flag
        }
      }
    }
  }
}

{
  "data": {
    "posts": [
      {
        "unflagged": {
          "edges": [
            {
              "node": {
                "id": "91971f9b-142f-491a-9373-fe282631848b",
                "flag": true
              }
            },
            {
              "node": {
                "id": "2fe20b67-1b40-4946-bc80-f6789057b4ee",
                "flag": true
              }
            }
          ]
        },
        "flagged": {
          "edges": [
            {
              "node": {
                "id": "91971f9b-142f-491a-9373-fe282631848b",
                "flag": true
              }
            },
            {
              "node": {
                "id": "2fe20b67-1b40-4946-bc80-f6789057b4ee",
                "flag": true
              }
            }
          ]
        }
      }
    ]
  }
}

unflagged last

query PostsWithFlaggedAndUnflaggedComments {
  posts {
    flagged: commentsConnection(where: { node: { flag: true } }) {
      edges {
        node {
          id
          flag
        }
      }
    }
    unflagged: commentsConnection(where: { node: { flag: false } }) {
      edges {
        node {
          id
          flag
        }
      }
    }
  }
}

{
  "data": {
    "posts": [
      {
        "flagged": {
          "edges": [
            {
              "node": {
                "id": "59036026-39e0-4761-99ab-9ed8ad369e0b",
                "flag": false
              }
            }
          ]
        },
        "unflagged": {
          "edges": [
            {
              "node": {
                "id": "59036026-39e0-4761-99ab-9ed8ad369e0b",
                "flag": false
              }
            }
          ]
        }
      }
    ]
  }
}

Expected Behavior

The library should be able to alias a connection field multiple times without overwriting any parameters.

Screenshots

Entire graph

System (please complete the following information):

• OS: [email protected]
• Version: @neo4j/[email protected]
• Node.js version: 14.16.0

Additional Context

Debugger output for PostsWithFlaggedAndUnflaggedComments

@neo4j/graphql:graphql Incoming GraphQL:
Query:
query PostsWithFlaggedAndUnflaggedComments {
  posts {
    flagged: commentsConnection(where: {node: {flag: true}}) {
      edges {
        node {
          id
          flag
        }
      }
    }
    unflagged: commentsConnection(where: {node: {flag: false}}) {
      edges {
        node {
          id
          flag
        }
      }
    }
  }
}
Variables:
{} +0ms
  @neo4j/graphql:auth Could not get .authorization, .Authorization or .cookies.token from req +0ms
  @neo4j/graphql:execute About to execute Cypher:
Cypher:
MATCH (this:Post)
CALL {
WITH this
MATCH (this)-[this_has_comment:HAS_COMMENT]->(this_comment:Comment)
WHERE this_comment.flag = $this_commentsConnection.args.where.node.flag
WITH collect({ node: { id: this_comment.id, flag: this_comment.flag } }) AS edges
RETURN { edges: edges, totalCount: size(edges) } AS flagged
}
CALL {
WITH this
MATCH (this)-[this_has_comment:HAS_COMMENT]->(this_comment:Comment)
WHERE this_comment.flag = $this_commentsConnection.args.where.node.flag
WITH collect({ node: { id: this_comment.id, flag: this_comment.flag } }) AS edges
RETURN { edges: edges, totalCount: size(edges) } AS unflagged
}
RETURN this { flagged, unflagged } as this
Params:
{
  "this_commentsConnection": {
    "args": {
      "where": {
        "node": {
          "flag": false
        }
      }
    }
  }
} +0ms
  @neo4j/graphql:execute Execute successful, received 1 records +13ms