Fix for connection with multiple aliases

[dmoree]

Description

Similar to #359, this adds the ability to have multiple aliases on connection fields without overwriting parameters by naming parameters after aliases and fields after names.

Issue

• Attributes get lost when calling a connection multiple times using aliases #392

Checklist

The following requirements should have been met (depending on the changes in the branch):

• Documentation has been updated
• TCK tests have been updated
• Integration tests have been updated
• Example applications have been updated
• New files have copyright header
• CLA (https://neo4j.com/developer/cla/) has been signed

[darrellwarde]

Hey @dmoree, thanks for this! This seems to have introduced a bug, highlighted in TCK test https://github.com/dmoree/graphql/blob/bugfix/alias-connection/packages/graphql/tests/tck/tck-test-files/cypher/connections/mixed-nesting.md#connection---connection---relationship

Where it is expecting Cypher arguments:

{
    "this_title": "Forrest Gump",
    "this_actor_movie_actors_name_NOT": "Tom Hanks",
    "this_actorsConnection": {
        "args": {
            "where": {
                "node": {
                    "name": "Tom Hanks"
                }
            }
        },
        "edges": {
            "node": {
                "moviesConnection": {
                    "args": {
                        "where": {
                            "node": {
                                "title_NOT": "Forrest Gump"
                            }
                        }
                    }
                }
            }
        }
    }
}

It is receiving:

{
    "this_title": "Forrest Gump",
    "this_actor_movie_actors_name_NOT": "Tom Hanks",
    "this_actorsConnection": {
        "args": {
            "where": {
                "node": {
                    "name": "Tom Hanks"
                }
            }
        },
        "edges": {
            "node": {
                "moviesConnection": undefined
            }
        }
    }
}

Seems like the movieConnection argument is now being dropped at some point.

[dmoree]

I apologize since I am not sure how to remedy this. I don't want to pollute the repo, however I created a different pull request #403 that makes the same changes to createConnectionAndParams and adds additional integration and tck tests which are passing.