Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove IsStandardContract #2400

Merged
merged 2 commits into from
Mar 16, 2021
Merged

Remove IsStandardContract #2400

merged 2 commits into from
Mar 16, 2021

Conversation

shargon
Copy link
Member

@shargon shargon commented Mar 15, 2021

Close #2399

@shargon shargon requested a review from erikzhang March 15, 2021 11:51
@cloud8little
Copy link
Contributor

cloud8little commented Mar 16, 2021 •
edited
Loading

Test when invokefunction with wallet open, since the wallet not sign, witness is null.

cacdc5861aa7c74323ccba31dfcec40

then send the transaction, check applicationlog, this time witness is not null.

e80fee4fe8cc0ea8fcf4b80c3ff12cf

@csmuller please have a check.

cloud8little
cloud8little previously approved these changes Mar 16, 2021
View reviewed changes
@superboyiii
Copy link
Member

@erikzhang Need your review.

@erikzhang
Copy link
Member

I think we can just remove the syscall IsStandardContract. It is useless now.

@superboyiii
Copy link
Member

superboyiii commented Mar 16, 2021 •
edited
Loading

@shargon Do we have any scenario to call IsStandardContract? Seems it's impossible to do this in contract.

@shargon shargon changed the title Check tx.Witnesses null when check IsStandardContract Remove IsStandardContract Mar 16, 2021
@shargon
Copy link
Member Author

shargon commented Mar 16, 2021

@shargon Do we have any scenario to call IsStandardContract? Seems it's impossible to do this in contract.

No, @roman-khimov what do you think?

@roman-khimov
Copy link
Contributor

@shargon Do we have any scenario to call IsStandardContract? Seems it's impossible to do this in contract.

No, @roman-khimov what do you think?

#1753, option №4 wins.

@superboyiii
Copy link
Member

Merge?

@erikzhang erikzhang merged commit d763437 into neo-project:master Mar 16, 2021
@erikzhang erikzhang deleted the is-standard-contract-check branch March 16, 2021 10:17
@csmuller csmuller mentioned this pull request Mar 16, 2021
Closed
@AnnaShaleva AnnaShaleva mentioned this pull request Mar 16, 2021
Merged
ixje added a commit to CityOfZion/neo-mamba that referenced this pull request Apr 20, 2021
@ixje
https://github.com/neo-project/neo/pull/2400
619d047
ixje added a commit to CityOfZion/neo-mamba that referenced this pull request Apr 30, 2021
@ixje
Rc1 (#84)
8b18e30 
* neo-project/neo#2295
* neo-project/neo#2290
* neo-project/neo#2292
* neo-project/neo#2296
* neo-project/neo#2301
* neo-project/neo#2298
* neo-project/neo#2312
* neo-project/neo#2300
* neo-project/neo#2333
* neo-project/neo#2337
* neo-project/neo#2331
* neo-project/neo#2332
* neo-project/neo#2343
* neo-project/neo#2339
* neo-project/neo#2350
* neo-project/neo#2351
* neo-project/neo#2353
* neo-project/neo#2356
* neo-project/neo#2375
* neo-project/neo#2377
* neo-project/neo#2379
* https://github.com/neo-project/neo/pull/2392/files
* neo-project/neo#2400
* audit updates
* refactor and bump VM requirement
@luc10921 luc10921 mentioned this pull request Jun 14, 2021
Closed
@dusmart
Copy link

dusmart commented Apr 28, 2022

Please remove this syscall's price in document. Thanks.
https://docs.neo.org/docs/zh-cn/reference/fees.html.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csmuller csmuller csmuller left review comments

@erikzhang erikzhang erikzhang approved these changes

@cloud8little cloud8little cloud8little left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

should check tx.Witnesses null when check IsStandardContract
7 participants
@shargon @cloud8little @superboyiii @erikzhang @roman-khimov @dusmart @csmuller