-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust native contract fee #2331
Conversation
When we call native contract, the fee is a fixed number now. Can we make this as a variable which can be adjusted by the Committee? |
Now all fees are controlled by the committee. |
Add storage fees to:
? |
I had a similar question, but
This becomes completely controlled with
Probably the most interesting candidate, but it only uses some additional space on the first vote, then you can change the vote in any way but no additional space will be used.
This will have a price setting of its own (
These do their own price calculations according to contract/manifest sizes. |
We have all of this methods free:
I think that we should have a minimum fee although for the committee. |
Why? |
Because this fee will be burned, and I think that they need to contribute as anyone |
Either is fine for me. @roman-khimov What do you think? |
I don't have a strong opinion here, committee-signed transactions (mostly price setters) are rare and special, if they don't pay for this invocation it's fine for me, if they pay, well, it works for me too (it shouldn't be a problem for committee to arrange enough GAS on the appropriate account). Maybe the only thing that would differ in this case is that if these calls are free then anyone (non-committee) can invoke them and not pay for it (the transaction will fail of course, but with a slightly more overhead than was paid for), not a huge deal but maybe this makes having some price slightly more favorable. |
Done. |
Go? |
Test passed, good to go. |
* neo-project/neo#2295 * neo-project/neo#2290 * neo-project/neo#2292 * neo-project/neo#2296 * neo-project/neo#2301 * neo-project/neo#2298 * neo-project/neo#2312 * neo-project/neo#2300 * neo-project/neo#2333 * neo-project/neo#2337 * neo-project/neo#2331 * neo-project/neo#2332 * neo-project/neo#2343 * neo-project/neo#2339 * neo-project/neo#2350 * neo-project/neo#2351 * neo-project/neo#2353 * neo-project/neo#2356 * neo-project/neo#2375 * neo-project/neo#2377 * neo-project/neo#2379 * https://github.com/neo-project/neo/pull/2392/files * neo-project/neo#2400 * audit updates * refactor and bump VM requirement
No description provided.