Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix FromJson #2350

Merged
merged 3 commits into from
Feb 17, 2021
Merged

Fix FromJson #2350

merged 3 commits into from
Feb 17, 2021

Conversation

erikzhang
Copy link
Member

@erikzhang erikzhang commented Feb 17, 2021 •
edited
Loading

Close #2349

@erikzhang
Copy link
Member Author

@roman-khimov

shargon
shargon reviewed Feb 17, 2021
View reviewed changes
Copy link
Member

@shargon shargon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignore case?

src/neo/SmartContract/ContractParameter.cs Show resolved Hide resolved
src/neo/SmartContract/Manifest/ContractMethodDescriptor.cs Show resolved Hide resolved
src/neo/SmartContract/Manifest/ContractParameterDefinition.cs Show resolved Hide resolved
shargon
shargon previously approved these changes Feb 17, 2021
View reviewed changes
@roman-khimov
Copy link
Contributor

NEP6 code also uses JObject with As* methods, worth fixing.

@erikzhang erikzhang merged commit da622ed into master Feb 17, 2021
@erikzhang erikzhang deleted the fix-fromjson branch February 17, 2021 14:57
ixje added a commit to CityOfZion/neo-mamba that referenced this pull request Apr 20, 2021
@ixje
https://github.com/neo-project/neo/pull/2350
27fcf00
ixje added a commit to CityOfZion/neo-mamba that referenced this pull request Apr 30, 2021
@ixje
Rc1 (#84)
8b18e30 
* neo-project/neo#2295
* neo-project/neo#2290
* neo-project/neo#2292
* neo-project/neo#2296
* neo-project/neo#2301
* neo-project/neo#2298
* neo-project/neo#2312
* neo-project/neo#2300
* neo-project/neo#2333
* neo-project/neo#2337
* neo-project/neo#2331
* neo-project/neo#2332
* neo-project/neo#2343
* neo-project/neo#2339
* neo-project/neo#2350
* neo-project/neo#2351
* neo-project/neo#2353
* neo-project/neo#2356
* neo-project/neo#2375
* neo-project/neo#2377
* neo-project/neo#2379
* https://github.com/neo-project/neo/pull/2392/files
* neo-project/neo#2400
* audit updates
* refactor and bump VM requirement
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shargon shargon shargon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expected JSON types are not enforced (or anything can be a string)
3 participants
@erikzhang @roman-khimov @shargon