Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-picks for 2.10.22-RC.1 #5979

Merged
merged 10 commits into from
Oct 9, 2024
Merged

Cherry-picks for 2.10.22-RC.1 #5979

merged 10 commits into from
Oct 9, 2024

Conversation

dependabot bot and others added 10 commits October 8, 2024 19:57
Bumps [go.uber.org/automaxprocs](https://github.com/uber-go/automaxprocs) from 1.5.3 to 1.6.0.
- [Release notes](https://github.com/uber-go/automaxprocs/releases)
- [Changelog](https://github.com/uber-go/automaxprocs/blob/master/CHANGELOG.md)
- [Commits](uber-go/automaxprocs@v1.5.3...v1.6.0)

---
updated-dependencies:
- dependency-name: go.uber.org/automaxprocs
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [github.com/klauspost/compress](https://github.com/klauspost/compress) from 1.17.9 to 1.17.10.
- [Release notes](https://github.com/klauspost/compress/releases)
- [Changelog](https://github.com/klauspost/compress/blob/master/.goreleaser.yml)
- [Commits](klauspost/compress@v1.17.9...v1.17.10)

---
updated-dependencies:
- dependency-name: github.com/klauspost/compress
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
As one was lost in the #3536

Signed-off-by: Alexander Kuleshov <[email protected]>
When checking interest state for interest or workqueue streams, we would
check all msgs from the streams first sequence through ack floor and up
to delivered.

We do this to make sure our ack state is correct. In cases where there
were alot of messages still in the stream due to offline or slow
consumers, this could be a heavy load on a server.

This improvement uses LoadNextMsg() to efficiently skip ahead and we now
remember our checked floor and do not repeat checks for messages below
our check floor on subsequent runs.

This change also highlighted a datarace in filestore that is fixed here
as well.

Signed-off-by: Derek Collison <[email protected]>

---------

Signed-off-by: Derek Collison <[email protected]>
This fixes that condition and also adds in compaction logic once we know the tombstones are no longer relevant.

Signed-off-by: Derek Collison <[email protected]>
…d by another one with more nulls we could recurse infinitely and panic the server.

We now changed the no pivot to 127(DEL) and enforce that you can not insert a subject with that byte. Also make sure we do not recursively call into insert with no cpi movement.

This condition was from an old server that had corrupted the PSIM data (known issue fixed), but we were not detecting it, so added test for this when checking runes under isValidSubject.

Signed-off-by: Derek Collison <[email protected]>
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@neilalexander neilalexander marked this pull request as ready for review October 9, 2024 08:39
@neilalexander neilalexander requested a review from a team as a code owner October 9, 2024 08:39
@neilalexander neilalexander merged commit 7f381e0 into release/v2.10.22 Oct 9, 2024
5 checks passed
@neilalexander neilalexander deleted the neil/21022rc1 branch October 9, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants