Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-picks for 2.10.22-RC.1 #5979

Merged
merged 10 commits into from
Oct 9, 2024
Merged

Cherry-picks for 2.10.22-RC.1 #5979

merged 10 commits into from
Oct 9, 2024

Commits on Oct 8, 2024

  1. Bump go.uber.org/automaxprocs from 1.5.3 to 1.6.0 

    Bumps [go.uber.org/automaxprocs](https://github.com/uber-go/automaxprocs) from 1.5.3 to 1.6.0.
- [Release notes](https://github.com/uber-go/automaxprocs/releases)
- [Changelog](https://github.com/uber-go/automaxprocs/blob/master/CHANGELOG.md)
- [Commits](uber-go/automaxprocs@v1.5.3...v1.6.0)

---
updated-dependencies:
- dependency-name: go.uber.org/automaxprocs
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
    @dependabot @neilalexander
    dependabot[bot] authored and neilalexander committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    7ad65ea View commit details
    Browse the repository at this point in the history

  2. Bump github.com/klauspost/compress from 1.17.9 to 1.17.10 

    Bumps [github.com/klauspost/compress](https://github.com/klauspost/compress) from 1.17.9 to 1.17.10.
- [Release notes](https://github.com/klauspost/compress/releases)
- [Changelog](https://github.com/klauspost/compress/blob/master/.goreleaser.yml)
- [Commits](klauspost/compress@v1.17.9...v1.17.10)

---
updated-dependencies:
- dependency-name: github.com/klauspost/compress
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
    @dependabot @neilalexander
    dependabot[bot] authored and neilalexander committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    d5ecf15 View commit details
    Browse the repository at this point in the history

  3. Fix desync after errCatchupTooManyRetries 

    Signed-off-by: Maurice van Veen <[email protected]>
    @MauriceVanVeen @neilalexander
    MauriceVanVeen authored and neilalexander committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    5c08f72 View commit details
    Browse the repository at this point in the history

  4. Warn if using temp storage for JetStream 

    Signed-off-by: Maurice van Veen <[email protected]>
    @MauriceVanVeen @neilalexander
    MauriceVanVeen authored and neilalexander committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    d826da8 View commit details
    Browse the repository at this point in the history

  5. Add missed angle bracket to the help output 

    As one was lost in the #3536

Signed-off-by: Alexander Kuleshov <[email protected]>
    @0xAX @neilalexander
    0xAX authored and neilalexander committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    91f671a View commit details
    Browse the repository at this point in the history

  6. Fix data race in processAppendEntry 

    Signed-off-by: Maurice van Veen <[email protected]>
    @MauriceVanVeen @neilalexander
    MauriceVanVeen authored and neilalexander committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    0af1a1a View commit details
    Browse the repository at this point in the history

  7. Updates for x/crypto, x/sys and x/time 

    Signed-off-by: Derek Collison <[email protected]>
    @derekcollison @neilalexander
    derekcollison authored and neilalexander committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    62d9360 View commit details
    Browse the repository at this point in the history

  8. [IMPROVED] Check stream state performance (#5963) 

    When checking interest state for interest or workqueue streams, we would
check all msgs from the streams first sequence through ack floor and up
to delivered.

We do this to make sure our ack state is correct. In cases where there
were alot of messages still in the stream due to offline or slow
consumers, this could be a heavy load on a server.

This improvement uses LoadNextMsg() to efficiently skip ahead and we now
remember our checked floor and do not repeat checks for messages below
our check floor on subsequent runs.

This change also highlighted a datarace in filestore that is fixed here
as well.

Signed-off-by: Derek Collison <[email protected]>

---------

Signed-off-by: Derek Collison <[email protected]>
    @derekcollison @neilalexander
    derekcollison authored and neilalexander committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    b753100 View commit details
    Browse the repository at this point in the history

  9. When writing tombstones we could violate max block size. 

    This fixes that condition and also adds in compaction logic once we know the tombstones are no longer relevant.

Signed-off-by: Derek Collison <[email protected]>
    @derekcollison @neilalexander
    derekcollison authored and neilalexander committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    e1d4b5d View commit details
    Browse the repository at this point in the history

  10. When a subject with embedded nulls was inserted into an stree followe… 

    …d by another one with more nulls we could recurse infinitely and panic the server.

We now changed the no pivot to 127(DEL) and enforce that you can not insert a subject with that byte. Also make sure we do not recursively call into insert with no cpi movement.

This condition was from an old server that had corrupted the PSIM data (known issue fixed), but we were not detecting it, so added test for this when checking runes under isValidSubject.

Signed-off-by: Derek Collison <[email protected]>
    @derekcollison @neilalexander
    derekcollison authored and neilalexander committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    660036d View commit details
    Browse the repository at this point in the history