Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UPDATED] Updates for x/crypto, x/sys and x/time dependencies #5971

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

derekcollison
Copy link
Member

Signed-off-by: Derek Collison [email protected]

@derekcollison derekcollison requested a review from a team as a code owner October 7, 2024 16:53
go 1.22.0
go 1.22

toolchain go1.22.8
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like there was a reason the go line was 1.22.0 and not 1.22, @wallyqs can you remember?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the time it was to avoid this issue: golang/go#62278 but it seems it may have been fixed in Go v1.22.4: golang/go#67236

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we dropped Go v1.21 already, I think it should work as it is in the PR right now: golang/go#62278 (comment)

Copy link
Member

@wallyqs wallyqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison derekcollison merged commit 9a41ec4 into main Oct 7, 2024
5 checks passed
@derekcollison derekcollison deleted the x-dependencies-updates branch October 7, 2024 17:42
neilalexander added a commit that referenced this pull request Oct 9, 2024
Includes the following:

- #5944
- #5945
- #5939
- #5935
- #5960
- #5970
- #5971
- #5963
- #5973
- #5978

Signed-off-by: Neil Twigg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants