Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2253, update naming convention document #2254

Merged
merged 1 commit into from
Apr 13, 2023

Conversation

jphickey
Copy link
Contributor

@jphickey jphickey commented Mar 9, 2023

Checklist (Please check before submitting)

Describe the contribution
Updates to cover event ID recommendations

Fixes #2253

Testing performed
N/A

Expected behavior changes
N/A - Documentation only

System(s) tested on
N/A

Additional context
This doc could really use additional updates to expand on command naming, CamelCase vs. APP_CAPS, etc.

Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.

Updates to cover event ID recommendations
@jphickey jphickey added the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label Mar 9, 2023
@dzbaker dzbaker marked this pull request as ready for review April 13, 2023 18:49
@dzbaker dzbaker added CCB:Approved Indicates code review and approval by community CCB and removed CCB:Ready Ready for discussion at the Configuration Control Board (CCB) labels Apr 13, 2023
dzbaker added a commit to nasa/cFS that referenced this pull request Apr 13, 2023
*Combines:*

cFE v7.0.0-rc4+dev268
sch_lab v2.5.0-rc4+dev53
to_lab v2.5.0-rc4+dev45

**Includes:**

*cFE*
- nasa/cFE#2254
- nasa/cFE#2288
- nasa/cFE#2290

*sch_lab*
- nasa/sch_lab#136

*to_lab*
- nasa/to_lab#139

Co-authored by: Joseph Hickey <[email protected]>
@dzbaker dzbaker merged commit ac62c5f into nasa:main Apr 13, 2023
dzbaker added a commit to nasa/cFS that referenced this pull request Apr 13, 2023
*Combines:*

cFE v7.0.0-rc4+dev268
sch_lab v2.5.0-rc4+dev53
to_lab v2.5.0-rc4+dev45

**Includes:**

*cFE*
- nasa/cFE#2254
- nasa/cFE#2288
- nasa/cFE#2290

*sch_lab*
- nasa/sch_lab#136

*to_lab*
- nasa/to_lab#139

Co-authored by: Joseph Hickey <[email protected]>
@jphickey jphickey deleted the fix-2253-naming-conv branch April 17, 2023 15:17
@dmknutsen dmknutsen added this to the Equuleus milestone May 26, 2023
@chillfig chillfig added the docs This change only affects documentation. label Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates code review and approval by community CCB docs This change only affects documentation. Equuleus-rc1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Naming conventions for events and other patterns
4 participants