Fix #2175, Apply consistent Event ID names to common events

[thnkslprpt]

Checklist

• I reviewed the Contributing Guide.
• I signed and emailed the appropriate Contributor License Agreement to [email protected] and copied [email protected].

Describe the contribution

• Fixes Inconsistent Event ID naming #2175
  • Consistent event IDs have been applied to the inconsistent cases to align them with a common Event ID naming convention.

Testing performed
Only GitHub CI actions.

Expected behavior changes
No impact on code behavior (no logic changes).
Consistent Event ID names for the events which are common to all/most cFS components and apps will improve consistency and ease make code review/debugging easier.

Contributor Info
Avi Weiss @thnkslprpt

[jphickey]

I think this is a good improvement on the event names, we should consider adding a paragraph to https://github.com/nasa/cFE/blob/main/docs/cFS_IdentifierNamingConvention.md that focuses on event names to document how the name should be constructed.

[thnkslprpt]

I think this is a good improvement on the event names, we should consider adding a paragraph to https://github.com/nasa/cFE/blob/main/docs/cFS_IdentifierNamingConvention.md that focuses on event names to document how the name should be constructed.

Yes good point - I will draft something up today and add it to that markdown doc.

[thnkslprpt]

I think this is a good improvement on the event names, we should consider adding a paragraph to https://github.com/nasa/cFE/blob/main/docs/cFS_IdentifierNamingConvention.md that focuses on event names to document how the name should be constructed.

I added the following section to the naming convention doc and squashed all the commits together now for merging.

[thnkslprpt]

I think this is a good improvement on the event names, we should consider adding a paragraph to https://github.com/nasa/cFE/blob/main/docs/cFS_IdentifierNamingConvention.md that focuses on event names to document how the name should be constructed.

@jphickey Joe - just making sure you're OK with the section I added to the naming convention doc.
Re-requested review as I added that commit here (and squashed it) after your original approval.

Removed the paragraph 8. that I added (see https://github.com/nasa/cFE/compare/4885bd1aacb0506e7784ac14931c09a48670fd9e..4820e166ef0bb0ebe7c074a0f8dbd0e2eeb6148f#) as something similar is already now present since #2254.