Don't use StringEnum subclasses over Qt Signal definition

[dalthviz]

Closes #94
Closes #103

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.52%. Comparing base (9be404a) to head (f7b8f1f).
Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #104      +/-   ##
==========================================
- Coverage   93.57%   93.52%   -0.06%     
==========================================
  Files          10       10              
  Lines        1822     1822              
==========================================
- Hits         1705     1704       -1     
- Misses        117      118       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jaimergp]

LGTM, but is there a way we can test this breakage? We didn't catch this bad crash before.

[dalthviz]

The thing that was causing the tests to not fail was that the validation that skipped the whole test_qt_plugin_dialog module was skipping it always if we were testing with PySide2 (due to an or instead of an and in the validation). The related change to prevent that is at: https://github.com/napari/napari-plugin-manager/pull/104/files#diff-7974331479a4c742a92ad157da87de3e8f3b2a5ec09707b208b4ca377c2bd6caL17-R17

With the change done, now the module gets skipped only when actually is necessary (when using Python >3.10 and PySide2). This skip is needed since there are no wheels for PySide2 5.15 for Python >3.10. Trying to install PySide2 causes PySide2 5.13 to be installed with Python >=3.11 and that comes with some issues.

I also checked that reverting the Signal change, while keeping the change for the validation to apply the skip, causes the tests (test_qt_plugin_dialog) to fail:

• Without the Signal definition change but having the validation change on Windows with Python 3.10:

• With the Signal definition change and also the validation change on Windows with Python 3.10:

[psobolewskiPhD]

Amazing sleuthing as always @dalthviz
❤️

[jaimergp]

Ok, thank you so much for the detailed explanation. Always a pleasure, let's merge this one.