Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use StringEnum subclasses over Qt Signal definition #104

Merged
merged 4 commits into from
Sep 24, 2024
Merged

Don't use StringEnum subclasses over Qt Signal definition #104

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dafe10c
Don't use 'StringEnum' subclasses over Qt Signal definition
dalthviz Sep 19, 2024
4e1a748
Testing
dalthviz Sep 19, 2024
358fdd5
Testing
dalthviz Sep 19, 2024
f7b8f1f
Testing
dalthviz Sep 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions napari_plugin_manager/_tests/test_qt_plugin_dialog.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,7 @@
from qtpy.QtCore import QMimeData, QPointF, Qt, QUrl
from qtpy.QtGui import QDropEvent

if (qtpy.API_NAME == 'PySide2') or (
sys.version_info[:2] > (3, 10) and platform.system() == "Linux"
):
if qtpy.API_NAME == 'PySide2' and sys.version_info[:2] > (3, 10):
pytest.skip(
"Known PySide2 x Python incompatibility: "
"... object cannot be interpreted as an integer",
Expand Down
5 changes: 2 additions & 3 deletions napari_plugin_manager/qt_plugin_dialog.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
from napari.plugins.utils import normalized_name
from napari.settings import get_settings
from napari.utils.misc import (
StringEnum,
parse_version,
running_as_constructor_app,
)
Expand Down Expand Up @@ -104,9 +105,7 @@ class PluginListItem(QFrame):
author, source, version, and buttons to update, install/uninstall, etc."""

# item, package_name, action_name, version, installer_choice
actionRequested = Signal(
QListWidgetItem, str, InstallerActions, str, InstallerTools
)
actionRequested = Signal(QListWidgetItem, str, StringEnum, str, StringEnum)

def __init__(
self,
Expand Down