Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing test with Pyside #94

Closed
Czaki opened this issue Aug 8, 2024 · 0 comments · Fixed by #104
Closed

Failing test with Pyside #94

Czaki opened this issue Aug 8, 2024 · 0 comments · Fixed by #104

Comments

@Czaki
Copy link
Contributor

Czaki commented Aug 8, 2024

The napari/napari#7138 PR shows crashes of the test related to plugin manager when using PySide backend.

I have skipped these tests, but it will be really nice to enable them again shortly.

Problematic tests are test_plugin_manager_action and test_import_plugin_manager from napari/_qt/_qapp_model/_tests/test_plugins_menu.py
@Czaki Czaki mentioned this issue Aug 8, 2024
Merged
This was referenced Sep 19, 2024
Closed
Merged
@dalthviz dalthviz mentioned this issue Sep 24, 2024
Merged
jni added a commit to napari/napari that referenced this issue Sep 29, 2024
@dalthviz @jni
Remove skip conditions for PySide2/6 over plugins menu tests and bump…
d20a1fc 
… `napari-plugin-manager` minimum version (>=0.1.3) (#7293)

# References and relevant issues

Part of napari/napari-plugin-manager#94
Follow up for #7138

# Description

* Remove skip conditions related with `napari-plugin-manager` and PySide
issues
* Bump minimum `napari-plugin-manager` version constraint to >=0.1.2
(need for a new `napari-plugin-manager` release)
* Following the discovery of still having issues related with PySide2
compatibility that need to be addressed over napari-plugin-manager
(napari/napari-plugin-manager#106) update
requirement to 0.1.3 release and update the constraints

---------

Co-authored-by: Juan Nunez-Iglesias <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't use StringEnum subclasses over Qt Signal definition dalthviz/napari-plugin-manager
1 participant
@Czaki