refactor(editor): Fix remaining FE type check errors (no-changelog) #9607

RicardoE105 · 2024-06-03T22:55:09Z

Summary

Reduce the number of type errors in the FE from 118 to 0.
Enable type checking as part of build.

Review / Merge checklist

PR title and summary are descriptive. Remember, the title automatically goes into the changelog. Use (no-changelog) otherwise. (conventions)

packages/editor-ui/src/components/SettingsLogStreaming/EventDestinationSettingsModal.ee.vue

mutdmour · 2024-06-04T09:27:57Z

packages/editor-ui/src/hooks/utils/hooksAddFakeDoorFeatures.ts

@@ -20,7 +21,7 @@ export function compileFakeDoorFeatures(): IFakeDoor[] {
 	if (loggingFeature) {
 		loggingFeature.actionBoxTitle += '.cloud';
 		loggingFeature.linkURL += '&edition=cloud';
-		loggingFeature.infoText = '';
+		loggingFeature.infoText = '' as BaseTextKey;


is this a valid basetext key? maybe we need to redefine the types here somehow?

…rrors

mutdmour

Awesome thank you for working on this 🙏🏽

mutdmour · 2024-06-06T09:11:55Z

packages/design-system/src/components/N8nFormInput/FormInput.vue

@@ -240,7 +240,7 @@ const validationError = computed<string | null>(() => {

 	if (error) {
 		if ('messageKey' in error) {
-			return t(error.messageKey, error.options as object);
+			return t(error.messageKey, error.options as string[]);


could this be better defined in the original type?

mutdmour · 2024-06-06T09:13:09Z

packages/editor-ui/src/components/CredentialEdit/CredentialEdit.vue

@@ -499,7 +499,7 @@ export default defineComponent({

 			this.credentialData = {
 				...this.credentialData,
-				scopes,
+				scopes: scopes as unknown as CredentialInformation,


could we define those better in the original type?

mutdmour · 2024-06-06T09:14:23Z

packages/editor-ui/src/components/CredentialEdit/CredentialSharing.ee.vue

 				return sharee.id === this.usersStore.currentUser?.id;
 			});
 		},
 		projects(): ProjectListItem[] {
 			return this.projectsStore.personalProjects.filter(
 				(project) =>
 					project.id !== this.credential?.homeProject?.id &&
-					project.id !== this.credentialData?.homeProject?.id,
+					project.id !== (this.credentialData?.homeProject as IDataObject)?.id,


could we define this better in the original object? I know cred types are messy, but we should avoid bandaid solutions here.

mutdmour · 2024-06-06T09:17:10Z

packages/editor-ui/vite.config.mts

@@ -77,7 +77,8 @@ const plugins = [
 	}),
 	vue(),
 ];
-if (process.env.ENABLE_TYPE_CHECKING === 'true') {
+
+if (!process.env.VITEST) {


mutdmour · 2024-06-06T09:28:55Z

packages/editor-ui/src/main.ts

@@ -50,7 +50,8 @@ app.mount('#app');
 if (!import.meta.env.PROD) {
 	// Make sure that we get all error messages properly displayed
 	// as long as we are not in production mode
-	window.onerror = (message, source, lineno, colno, error) => {
+	window.onerror = (message, _source, _lineno, _colno, error) => {
+		// eslint-disable-next-line @typescript-eslint/no-base-to-string


could this be handled differently?

I don't think so. What do you have in mind?

will trust your judgement here

mutdmour · 2024-06-06T09:29:45Z

packages/editor-ui/src/plugins/connectors/N8nCustomConnector.ts

@@ -517,7 +517,7 @@ export class N8nConnector extends AbstractConnector {
 	}

 	resetTargetEndpoint() {
-		this.overrideTargetEndpoint = null;
+		this.overrideTargetEndpoint = null as unknown as Endpoint;


seems like we have to fix the types here.

Not much I can do. We're extending AbstractEndpoint and just using different types. I'm afraid of the side effects of removing all those null assignments. Should we try to tackle this separately?

Sure maybe we can add a todo or open a story?

Created https://linear.app/n8n/issue/N8N-7439/fix-n8ncustomconnector-types

packages/editor-ui/src/utils/apiUtils.ts

cstuncsik · 2024-06-10T11:14:40Z

packages/workflow/src/Interfaces.ts

@@ -116,21 +116,21 @@ export interface IUser {
 	lastName: string;
 }

+export type ProjectSharingData = {


Thanks 😍

mutdmour

Awesome. Thanks for addressing my feedback

mutdmour · 2024-06-10T11:32:27Z

packages/editor-ui/src/utils/typeGuards.ts

@@ -73,3 +73,9 @@ export function isTriggerPanelObject(
 ): triggerPanel is TriggerPanelDefinition {
 	return triggerPanel !== undefined && typeof triggerPanel === 'object' && triggerPanel !== null;
 }
+
+export function isFullExecutionResponse(


cypress · 2024-06-10T12:06:49Z

2 flaky tests on run #5388 ↗︎

0	364	0	0	2

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 RicardoE105 🗃️ e2e/*
Project: n8n	Commit: `2f34777f0a`
Status: Passed	Duration: 04:58 💡
Started: Jun 10, 2024 12:59 PM	Ended: Jun 10, 2024 1:04 PM

5-ndv.cy.ts • 1 flaky test

View Output Video

Test		Artifacts
NDV > Stop listening for trigger event from NDV		`Screenshots` `Video`

20-workflow-executions.cy.ts • 1 flaky test

View Output Video

Test		Artifacts
Current Workflow Executions > should auto load more items if there is space and auto scroll		`Test Replay` `Screenshots` `Video`

Review all test suite changes for PR #9607 ↗︎

github-actions · 2024-06-10T12:06:51Z

✅ All Cypress E2E specs passed

packages/editor-ui/src/components/CredentialEdit/CredentialEdit.vue

packages/editor-ui/src/components/CredentialEdit/CredentialSharing.ee.vue

packages/editor-ui/src/components/HoverableNodeIcon.vue

packages/editor-ui/src/components/NodeSettingsTabs.vue

packages/editor-ui/src/composables/useNodeHelpers.ts

packages/editor-ui/src/stores/credentials.store.ts

packages/editor-ui/src/stores/templates.store.ts

packages/editor-ui/src/views/TemplatesSearchView.vue

github-actions · 2024-06-10T13:04:01Z

✅ All Cypress E2E specs passed

* master: feat(editor): Harmonize rendering of new-lines in RunData (#9614) refactor(editor): Fix remaining FE type check errors (no-changelog) (#9607) fix(editor): Remove template creds setup from workflow when copied (no-changelog) (#9673) refactor(editor): Stop expecting `null` execution status (no-changelog) (#9672)

* master: feat(editor): Harmonize rendering of new-lines in RunData (#9614) refactor(editor): Fix remaining FE type check errors (no-changelog) (#9607) fix(editor): Remove template creds setup from workflow when copied (no-changelog) (#9673) refactor(editor): Stop expecting `null` execution status (no-changelog) (#9672) fix: Fix typo with submitted (no-changelog) (#9662) refactor(core): Revamp crash recovery mechanism for main mode (#9613) fix(editor): Improve dragndrop of input pills with spaces (#9656) fix(editor): Indent on tabs in expression fields (#9659) fix(editor): Color node connections correctly in execution preview for nodes that have pinned data (#9669) fix(core): Fix optional chaining in continue on fail check (#9667) feat(OpenAI Node): Allow to select Image analyze model & improve types (#9660)

janober · 2024-06-12T14:06:33Z

Got released with [email protected]

RicardoE105 changed the title ~~fix more type errors in the FE~~ Fix(editor-ui) More type errors in the FE (no-changelog) Jun 3, 2024

RicardoE105 changed the title ~~Fix(editor-ui) More type errors in the FE (no-changelog)~~ fix(editor): More type errors in the FE (no-changelog) Jun 3, 2024

fix type issues in the FE

e5fbbb7

RicardoE105 force-pushed the fe-type-errors branch from 2fecc2f to e5fbbb7 Compare June 3, 2024 23:00

n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Jun 3, 2024

remove unused type

21fc8e2

RicardoE105 requested a review from mutdmour June 4, 2024 01:15

mutdmour reviewed Jun 4, 2024

View reviewed changes

RicardoE105 and others added 3 commits June 4, 2024 17:17

fix typo

6dab7f4

refactor: fix remaining type errors

86ef27b

Merge branch 'fe-type-errors' of github.com:n8n-io/n8n into fe-type-e…

79a13f7

…rrors

alexgrozav assigned alexgrozav and RicardoE105 Jun 5, 2024

alexgrozav changed the title ~~fix(editor): More type errors in the FE (no-changelog)~~ refactor(editor): Fix remaining FE type check errors (no-changelog) Jun 5, 2024

alexgrozav added 5 commits June 5, 2024 16:07

fix: fix broken tests

6d19c88

fix: fix test

f9d9e8d

fix: fix mixin type

bdd4981

fix: update types

7b2db1f

fix: fix linting issues

764ea66

mutdmour reviewed Jun 6, 2024

View reviewed changes

alexgrozav added 4 commits June 10, 2024 10:37

chore: merge master

13b3c98

fix: fix remaining typecheck errors

6180b5d

fix: fix credential data type

c8155c3

fix: undo status changes

1513d59

cstuncsik reviewed Jun 10, 2024

View reviewed changes

alexgrozav added 2 commits June 10, 2024 14:15

fix: fix newly introduced executions typecheck errors.

2b45757

fix: fix npm run dev

a2a247c

mutdmour previously approved these changes Jun 10, 2024

View reviewed changes

fix: fix linting issue

22959fb

alexgrozav dismissed mutdmour’s stale review via 22959fb June 10, 2024 11:53

mutdmour previously approved these changes Jun 10, 2024

View reviewed changes

OlegIvaniv reviewed Jun 10, 2024

View reviewed changes

fix: address PR feedback

2f34777

alexgrozav dismissed mutdmour’s stale review via 2f34777 June 10, 2024 12:27

alexgrozav requested a review from OlegIvaniv June 10, 2024 12:51

OlegIvaniv approved these changes Jun 10, 2024

View reviewed changes

alexgrozav merged commit 22bdb05 into master Jun 10, 2024
44 checks passed

alexgrozav deleted the fe-type-errors branch June 10, 2024 13:23

janober added the Released label Jun 12, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor(editor): Fix remaining FE type check errors (no-changelog) #9607

refactor(editor): Fix remaining FE type check errors (no-changelog) #9607

RicardoE105 commented Jun 3, 2024 •

edited by alexgrozav

Loading

mutdmour Jun 4, 2024

mutdmour left a comment

mutdmour Jun 6, 2024

alexgrozav Jun 10, 2024

mutdmour Jun 6, 2024

alexgrozav Jun 10, 2024

mutdmour Jun 6, 2024

alexgrozav Jun 10, 2024

mutdmour Jun 6, 2024

mutdmour Jun 6, 2024

alexgrozav Jun 10, 2024

mutdmour Jun 10, 2024

mutdmour Jun 6, 2024

alexgrozav Jun 10, 2024

mutdmour Jun 10, 2024

alexgrozav Jun 10, 2024

cstuncsik Jun 10, 2024

mutdmour left a comment

mutdmour Jun 10, 2024

cypress bot commented Jun 10, 2024 •

edited

Loading

github-actions bot commented Jun 10, 2024

github-actions bot commented Jun 10, 2024

janober commented Jun 12, 2024

refactor(editor): Fix remaining FE type check errors (no-changelog) #9607

refactor(editor): Fix remaining FE type check errors (no-changelog) #9607

Conversation

RicardoE105 commented Jun 3, 2024 • edited by alexgrozav Loading

Summary

Review / Merge checklist

Choose a reason for hiding this comment

mutdmour left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mutdmour left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cypress bot commented Jun 10, 2024 • edited Loading

2 flaky tests on run #5388 ↗︎

Review all test suite changes for PR #9607 ↗︎

github-actions bot commented Jun 10, 2024

github-actions bot commented Jun 10, 2024

janober commented Jun 12, 2024

RicardoE105 commented Jun 3, 2024 •

edited by alexgrozav

Loading

cypress bot commented Jun 10, 2024 •

edited

Loading