fix: address PR feedback

n8n-io · Jun 10, 2024 · 2f34777 · 2f34777
1 parent 22959fb
commit 2f34777
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 17 deletions.
diff --git a/packages/editor-ui/src/components/CredentialEdit/CredentialEdit.vue b/packages/editor-ui/src/components/CredentialEdit/CredentialEdit.vue
@@ -1115,8 +1115,6 @@ export default defineComponent({
 						oauthTokenData: {} as CredentialInformation,
 					};
 
-					this.credentialsStore.enableOAuthCredential(credential);
-
 					// Close the window
 					if (oauthPopup) {
 						oauthPopup.close();

diff --git a/packages/editor-ui/src/components/CredentialEdit/CredentialSharing.ee.vue b/packages/editor-ui/src/components/CredentialEdit/CredentialSharing.ee.vue
@@ -169,11 +169,9 @@ export default defineComponent({
 				: undefined;
 		},
 		isCredentialSharedWithCurrentUser(): boolean {
-			return (
-				Array.isArray(this.credentialData.sharedWithProjects)
-					? this.credentialData.sharedWithProjects
-					: []
-			).some((sharee) => {
+			if (!Array.isArray(this.credentialData.sharedWithProjects)) return false;
+
+			return this.credentialData.sharedWithProjects.some((sharee) => {
 				return typeof sharee === 'object' && 'id' in sharee
 					? sharee.id === this.usersStore.currentUser?.id
 					: false;

diff --git a/packages/editor-ui/src/components/HoverableNodeIcon.vue b/packages/editor-ui/src/components/HoverableNodeIcon.vue
@@ -126,7 +126,7 @@ export default defineComponent({
 
 			const restUrl = this.rootStore.getRestUrl;
 
-			if (nodeType.icon && typeof nodeType.icon === 'string') {
+			if (typeof nodeType.icon === 'string') {
 				const [type, path] = nodeType.icon.split(':');
 				const returnData: NodeIconData = {
 					type,

diff --git a/packages/editor-ui/src/stores/credentials.store.ts b/packages/editor-ui/src/stores/credentials.store.ts
@@ -236,9 +236,6 @@ export const useCredentialsStore = defineStore(STORES.CREDENTIALS, {
 				};
 			}
 		},
-		enableOAuthCredential(_credential: ICredentialsResponse): void {
-			// enable oauth event to track change between modals
-		},
 		async fetchCredentialTypes(forceFetch: boolean): Promise<void> {
 			if (this.allCredentialTypes.length > 0 && !forceFetch) {
 				return;

diff --git a/packages/editor-ui/src/views/TemplatesSearchView.vue b/packages/editor-ui/src/views/TemplatesSearchView.vue
@@ -126,12 +126,7 @@ export default defineComponent({
 		const contentArea = document.getElementById('content');
 		if (contentArea) {
 			// When leaving this page, store current scroll position in route data
-			if (
-				this.$route.meta?.setScrollPosition &&
-				typeof this.$route.meta.setScrollPosition === 'function'
-			) {
-				this.$route.meta.setScrollPosition(contentArea.scrollTop);
-			}
+			this.$route.meta?.setScrollPosition?.(contentArea.scrollTop);
 		}
 
 		this.trackSearch();