refactor(editor): Stop expecting null execution status (no-changelog)
#9672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
core
cstuncsik
approved these changes
Jun 10, 2024
|
✅ All Cypress E2E specs passed |
1 failed and 1 flaky tests on run #5380 ↗︎
Details:
|
|||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| NpsSurvey > allows user to ignore survey 3 times before stopping to show until 6 months later |
Test Replay
Screenshots
Video
|
|
The first 5 failed specs are shown, see all 37 specs in Cypress Cloud.
cypress/e2e/5-ndv.cy.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| NDV > Stop listening for trigger event from NDV |
Screenshots
Video
|
|
Review all test suite changes for PR #9672 ↗︎
MiloradFilipovic
added a commit
that referenced
this pull request
Jun 10, 2024
* master: feat(editor): Harmonize rendering of new-lines in RunData (#9614) refactor(editor): Fix remaining FE type check errors (no-changelog) (#9607) fix(editor): Remove template creds setup from workflow when copied (no-changelog) (#9673) refactor(editor): Stop expecting `null` execution status (no-changelog) (#9672)
MiloradFilipovic
added a commit
that referenced
this pull request
Jun 10, 2024
* master: feat(editor): Harmonize rendering of new-lines in RunData (#9614) refactor(editor): Fix remaining FE type check errors (no-changelog) (#9607) fix(editor): Remove template creds setup from workflow when copied (no-changelog) (#9673) refactor(editor): Stop expecting `null` execution status (no-changelog) (#9672) fix: Fix typo with submitted (no-changelog) (#9662) refactor(core): Revamp crash recovery mechanism for main mode (#9613) fix(editor): Improve dragndrop of input pills with spaces (#9656) fix(editor): Indent on tabs in expression fields (#9659) fix(editor): Color node connections correctly in execution preview for nodes that have pinned data (#9669) fix(core): Fix optional chaining in continue on fail check (#9667) feat(OpenAI Node): Allow to select Image analyze model & improve types (#9660)
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://linear.app/n8n/issue/PAY-1643
e2e: https://github.com/n8n-io/n8n/actions/runs/9417968888