Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Revert 30k stars banner (no-changelog) #6347

Merged
merged 1 commit into from
Jun 1, 2023

Conversation

ivov
Copy link
Contributor

@ivov ivov commented Jun 1, 2023

@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2023

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Files matching **/*.vue:

  • Used composition API for all new components.
  • Added component or unit tests to cover functionality.

Files matching packages/editor-ui/**/*.vue:

  • Added E2E if adding new features.
  • Used design system tokens (colors, spacings...) where possible.

Make sure to check off this list before asking for review.

@codecov
Copy link

codecov bot commented Jun 1, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.03 ⚠️

Comparison is base (1b32141) 28.31% compared to head (c6aefe6) 28.29%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6347      +/-   ##
==========================================
- Coverage   28.31%   28.29%   -0.03%     
==========================================
  Files        2982     2982              
  Lines      185129   185098      -31     
  Branches    20295    20288       -7     
==========================================
- Hits        52425    52369      -56     
- Misses     131919   131944      +25     
  Partials      785      785              
Impacted Files Coverage Δ
packages/editor-ui/src/constants.ts 97.55% <ø> (-0.02%) ⬇️
packages/editor-ui/src/plugins/icons/index.ts 100.00% <ø> (ø)
...-ui/src/components/layouts/ResourcesListLayout.vue 71.08% <100.00%> (-1.16%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Jun 1, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2023

✅ All Cypress E2E specs passed

@ivov ivov merged commit 33e7ff8 into master Jun 1, 2023
@ivov ivov deleted the revert-30k-stars-banner branch June 1, 2023 09:22
MiloradFilipovic added a commit that referenced this pull request Jun 2, 2023
* master:
  fix(editor): Fix an issue with connections breaking during renaming (#6358)
  fix(core): Upgrade @n8n_io/riot-tmpl (no-changelog) (#6357)
  fix: Show actual execution data for production executions even if pin data exists (#6302)
  fix: Improve executions list polling performance (#6355)
  refactor: Revert 30k stars banner (no-changelog) (#6347)
  refactor: Add deprecation notice for basic auth and JWT auth (#6349)
  fix: Prevent redirect when outside of executions home (no-changelog) (#6305)
@janober
Copy link
Member

janober commented Jun 14, 2023

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants