Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Prevent redirect when outside of executions home (no-changelog) #6305

Merged
merged 1 commit into from
Jun 1, 2023

Conversation

alexgrozav
Copy link
Member

Github issue / Community forum post (link here to close automatically):

@alexgrozav alexgrozav requested a review from cstuncsik May 23, 2023 13:08
@github-actions
Copy link
Contributor

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching **/*.vue:

  • Used composition API for all new components.
  • Added component or unit tests to cover functionality.

Files matching packages/editor-ui/**/*.vue:

  • Added E2E if adding new features.
  • Used design system tokens (colors, spacings...) where possible.

Make sure to check off this list before asking for review.

@alexgrozav alexgrozav changed the title fix: prevent redirect when outside of executions home (no-changelog) fix: Prevent redirect when outside of executions home (no-changelog) May 23, 2023
@codecov
Copy link

codecov bot commented May 23, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (4b85433) 27.60% compared to head (ca12330) 27.60%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6305      +/-   ##
==========================================
- Coverage   27.60%   27.60%   -0.01%     
==========================================
  Files        2957     2957              
  Lines      181205   181208       +3     
  Branches    19699    19699              
==========================================
  Hits        50023    50023              
- Misses     130435   130438       +3     
  Partials      747      747              
Impacted Files Coverage Δ
...i/src/components/ExecutionsView/ExecutionsList.vue 13.98% <0.00%> (-0.06%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels May 23, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2023

✅ All Cypress E2E specs passed

@alexgrozav alexgrozav merged commit f7708c9 into master Jun 1, 2023
@alexgrozav alexgrozav deleted the pay-429-manual-executions-not-appearing-in-the branch June 1, 2023 09:21
MiloradFilipovic added a commit that referenced this pull request Jun 2, 2023
* master:
  fix(editor): Fix an issue with connections breaking during renaming (#6358)
  fix(core): Upgrade @n8n_io/riot-tmpl (no-changelog) (#6357)
  fix: Show actual execution data for production executions even if pin data exists (#6302)
  fix: Improve executions list polling performance (#6355)
  refactor: Revert 30k stars banner (no-changelog) (#6347)
  refactor: Add deprecation notice for basic auth and JWT auth (#6349)
  fix: Prevent redirect when outside of executions home (no-changelog) (#6305)
@janober
Copy link
Member

janober commented Jun 14, 2023

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants