Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Revert 30k stars banner (no-changelog) #6347

Merged
merged 1 commit into from
Jun 1, 2023
Merged

refactor: Revert 30k stars banner (no-changelog) #6347

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 1 addition & 27 deletions packages/editor-ui/src/components/layouts/ResourcesListLayout.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,20 +61,6 @@
<page-view-layout-list :overflow="type !== 'list'" v-else>
<template #header>
<div class="mb-xs">
<n8n-callout
v-if="starsBannerShouldRender"
theme="secondary"
icon="star"
:class="$style['github-stars-banner']"
>
<span v-html="$locale.baseText('githubStars.banner.title')"></span>
<template #trailingContent>
<n8n-link :to="repoUrl" size="small" theme="secondary" bold underline>
{{ $locale.baseText('githubStars.banner.link') }}
</n8n-link>
</template>
</n8n-callout>

<div :class="$style['filters-row']">
<n8n-input
:class="[$style['search'], 'mr-2xs']"
Expand Down Expand Up @@ -202,11 +188,7 @@ import { mapStores } from 'pinia';
import type { IUser } from '@/Interface';
import PageViewLayout from '@/components/layouts/PageViewLayout.vue';
import PageViewLayoutList from '@/components/layouts/PageViewLayoutList.vue';
import {
EnterpriseEditionFeature,
GITHUB_STARS_BANNER_SHOW_UNTIL_DATE,
MAIN_REPOSITORY_URL,
} from '@/constants';
import { EnterpriseEditionFeature } from '@/constants';
import { debounceHelper } from '@/mixins/debounce';
import ResourceOwnershipSelect from '@/components/forms/ResourceOwnershipSelect.ee.vue';
import ResourceFiltersDropdown from '@/components/forms/ResourceFiltersDropdown.vue';
Expand Down Expand Up @@ -313,14 +295,10 @@ export default defineComponent({
rowsPerPage: 10 as number | '*',
resettingFilters: false,
EnterpriseEditionFeature,
repoUrl: MAIN_REPOSITORY_URL,
};
},
computed: {
...mapStores(useSettingsStore, useUsersStore),
starsBannerShouldRender() {
return this.resourceKey === 'workflows' && new Date() < GITHUB_STARS_BANNER_SHOW_UNTIL_DATE;
},
subviewResources(): IResource[] {
if (!this.shareable) {
return this.resources as IResource[];
Expand Down Expand Up @@ -555,8 +533,4 @@ export default defineComponent({
.datatable {
padding-bottom: var(--spacing-s);
}

.github-stars-banner {
margin-bottom: var(--spacing-m);
}
</style>
3 changes: 0 additions & 3 deletions packages/editor-ui/src/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,6 @@ export const COMMUNITY_NODES_BLOCKLIST_DOCS_URL = `https://${DOCS_DOMAIN}/integr
export const CUSTOM_NODES_DOCS_URL = `https://${DOCS_DOMAIN}/integrations/creating-nodes/code/create-n8n-nodes-module/`;
export const EXPRESSIONS_DOCS_URL = `https://${DOCS_DOMAIN}/code-examples/expressions/`;
export const N8N_PRICING_PAGE_URL = 'https://n8n.io/pricing';
export const MAIN_REPOSITORY_URL = 'https://github.com/n8n-io/n8n';

// node types
export const BAMBOO_HR_NODE_TYPE = 'n8n-nodes-base.bambooHr';
Expand Down Expand Up @@ -562,8 +561,6 @@ export const ALLOWED_HTML_TAGS = [
'summary',
];

export const GITHUB_STARS_BANNER_SHOW_UNTIL_DATE = new Date('2023-06-01');

export const CLOUD_CHANGE_PLAN_PAGE = window.location.host.includes('stage-app.n8n.cloud')
? 'https://stage-app.n8n.cloud/account/change-plan'
: 'https://app.n8n.cloud/account/change-plan';
Expand Down
2 changes: 0 additions & 2 deletions packages/editor-ui/src/plugins/i18n/locales/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -597,8 +597,6 @@
"genericHelpers.secShort": "s",
"genericHelpers.showMessage.message": "Executions are read-only. Make changes from the <b>Workflow</b> tab.",
"genericHelpers.showMessage.title": "Cannot edit execution",
"githubStars.banner.title": "<b>Celebrating 30,000 stars on GitHub!</b> A big thank you to our community for your amazing support and contributions",
"githubStars.banner.link": "Star us on GitHub",
"mainSidebar.aboutN8n": "About n8n",
"mainSidebar.confirmMessage.workflowDelete.cancelButtonText": "",
"mainSidebar.confirmMessage.workflowDelete.confirmButtonText": "Yes, delete",
Expand Down
2 changes: 0 additions & 2 deletions packages/editor-ui/src/plugins/icons/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,6 @@ import {
faSignOutAlt,
faSlidersH,
faSpinner,
faStar,
faStop,
faSun,
faSync,
Expand Down Expand Up @@ -249,7 +248,6 @@ addIcon(faSlidersH);
addIcon(faSpinner);
addIcon(faSolidStickyNote);
addIcon(faStickyNote as IconDefinition);
addIcon(faStar);
addIcon(faStop);
addIcon(faSun);
addIcon(faSync);
Expand Down