-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): Manage version control settings #6079
feat(core): Manage version control settings #6079
Conversation
Great PR! Please pay attention to the following items before merging: Files matching
Files matching
Make sure to check off this list before asking for review. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #6079 +/- ##
==========================================
+ Coverage 18.59% 18.63% +0.03%
==========================================
Files 2585 2584 -1
Lines 116646 116434 -212
Branches 18181 18183 +2
==========================================
+ Hits 21694 21697 +3
+ Misses 94318 94101 -217
- Partials 634 636 +2
... and 11 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I'm not sure if you're planning on doing this now, but it'd be great to add tests for those endpoints |
not forgotten, but will be part of a future pr |
✅ All Cypress E2E specs passed |
* expand VersionControlPreferences * use Authorized decorator for vc endpoints instead of middleware * validate preferences with class-validator * cleanup * cleanup
* master: feat(core): Manage version control settings (#6079) ci: Fix linting error on `master` (no-changelog) (#6075) ci: Increase the timeout on the release process (no-changelog) (#6078) fix(editor): Update LDAP and Log streaming paywalls (#6069) feat(core): Add instanceId to n8n.ready hook (no-changelog) (#6007) ci: Update linting dependencies, and setup eslint-plugin-unicorn (no-changelog) (#6070)
…rce-mapper-ui-P2 * feature/resource-mapping-component: feat(core): Manage version control settings (#6079) ci: Fix linting error on `master` (no-changelog) (#6075) ci: Increase the timeout on the release process (no-changelog) (#6078) fix(editor): Update LDAP and Log streaming paywalls (#6069) feat(core): Add instanceId to n8n.ready hook (no-changelog) (#6007) ci: Update linting dependencies, and setup eslint-plugin-unicorn (no-changelog) (#6070)
Got released with |
No description provided.