Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): Manage version control settings #6079

Merged
merged 6 commits into from
Apr 24, 2023

Conversation

flipswitchingmonkey
Copy link
Contributor

No description provided.

@flipswitchingmonkey flipswitchingmonkey marked this pull request as ready for review April 24, 2023 13:53
@github-actions
Copy link
Contributor

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Make sure to check off this list before asking for review.

@codecov
Copy link

codecov bot commented Apr 24, 2023

Codecov Report

Patch coverage: 60.00% and project coverage change: +0.03 🎉

Comparison is base (308a943) 18.59% compared to head (d6f6fdb) 18.63%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6079      +/-   ##
==========================================
+ Coverage   18.59%   18.63%   +0.03%     
==========================================
  Files        2585     2584       -1     
  Lines      116646   116434     -212     
  Branches    18181    18183       +2     
==========================================
+ Hits        21694    21697       +3     
+ Misses      94318    94101     -217     
- Partials      634      636       +2     
Impacted Files Coverage Δ
...trol/middleware/versionControlEnabledMiddleware.ts 44.44% <ø> (+5.98%) ⬆️
...nments/versionControl/versionControl.service.ee.ts 53.33% <48.27%> (-13.34%) ⬇️
...nts/versionControl/versionControl.controller.ee.ts 66.66% <50.00%> (-23.34%) ⬇️
.../versionControl/types/versionControlPreferences.ts 92.30% <91.66%> (-7.70%) ⬇️
...nvironments/versionControl/versionControlHelper.ts 78.26% <100.00%> (ø)

... and 11 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Apr 24, 2023
Copy link
Contributor

@krynble krynble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@krynble
Copy link
Contributor

krynble commented Apr 24, 2023

I'm not sure if you're planning on doing this now, but it'd be great to add tests for those endpoints

@flipswitchingmonkey
Copy link
Contributor Author

I'm not sure if you're planning on doing this now, but it'd be great to add tests for those endpoints

not forgotten, but will be part of a future pr

@github-actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@flipswitchingmonkey flipswitchingmonkey merged commit f3b4701 into master Apr 24, 2023
@flipswitchingmonkey flipswitchingmonkey deleted the pay-370-manage-version-control-settings branch April 24, 2023 15:13
sunilrr pushed a commit to fl-g6/qp-n8n that referenced this pull request Apr 24, 2023
* expand VersionControlPreferences

* use Authorized decorator for vc endpoints instead of middleware

* validate preferences with class-validator

* cleanup

* cleanup
MiloradFilipovic added a commit that referenced this pull request Apr 25, 2023
* master:
  feat(core): Manage version control settings (#6079)
  ci: Fix linting error on `master` (no-changelog) (#6075)
  ci: Increase the timeout on the release process (no-changelog) (#6078)
  fix(editor): Update LDAP and Log streaming paywalls (#6069)
  feat(core): Add instanceId to n8n.ready hook (no-changelog) (#6007)
  ci: Update linting dependencies, and setup eslint-plugin-unicorn (no-changelog) (#6070)
MiloradFilipovic added a commit that referenced this pull request Apr 25, 2023
…rce-mapper-ui-P2

* feature/resource-mapping-component:
  feat(core): Manage version control settings (#6079)
  ci: Fix linting error on `master` (no-changelog) (#6075)
  ci: Increase the timeout on the release process (no-changelog) (#6078)
  fix(editor): Update LDAP and Log streaming paywalls (#6069)
  feat(core): Add instanceId to n8n.ready hook (no-changelog) (#6007)
  ci: Update linting dependencies, and setup eslint-plugin-unicorn (no-changelog) (#6070)
@janober
Copy link
Member

janober commented May 2, 2023

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants