Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Update linting dependencies, and setup eslint-plugin-unicorn (no-changelog) #6070

Merged
merged 3 commits into from
Apr 24, 2023

Conversation

netroy
Copy link
Member

@netroy netroy commented Apr 24, 2023

This should fail until #6041 is merged

@netroy netroy requested a review from ivov April 24, 2023 10:29
@n8n-assistant n8n-assistant bot added the n8n team Authored by the n8n team label Apr 24, 2023
@github-actions
Copy link
Contributor

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Make sure to check off this list before asking for review.

Copy link
Contributor

@ivov ivov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending #6041. (PR title has a typo.)

Will also update dependencies in the nodelinter once we merge this, to keep them in sync.

@codecov
Copy link

codecov bot commented Apr 24, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (308a943) 18.59% compared to head (e59499d) 18.59%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6070   +/-   ##
=======================================
  Coverage   18.59%   18.59%           
=======================================
  Files        2585     2585           
  Lines      116646   116646           
  Branches    18181    18181           
=======================================
  Hits        21694    21694           
  Misses      94318    94318           
  Partials      634      634           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@netroy netroy changed the title ci: Update liniting dependencies, and setup eslint-plugin-unicorn (no-changelog) ci: Update linting dependencies, and setup eslint-plugin-unicorn (no-changelog) Apr 24, 2023
@netroy netroy requested a review from ivov April 24, 2023 11:38
@github-actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@netroy netroy merged commit c7b1920 into master Apr 24, 2023
@netroy netroy deleted the upgrade-linting-setup branch April 24, 2023 12:47
sunilrr pushed a commit to fl-g6/qp-n8n that referenced this pull request Apr 24, 2023
MiloradFilipovic added a commit that referenced this pull request Apr 25, 2023
* master:
  feat(core): Manage version control settings (#6079)
  ci: Fix linting error on `master` (no-changelog) (#6075)
  ci: Increase the timeout on the release process (no-changelog) (#6078)
  fix(editor): Update LDAP and Log streaming paywalls (#6069)
  feat(core): Add instanceId to n8n.ready hook (no-changelog) (#6007)
  ci: Update linting dependencies, and setup eslint-plugin-unicorn (no-changelog) (#6070)
MiloradFilipovic added a commit that referenced this pull request Apr 25, 2023
…rce-mapper-ui-P2

* feature/resource-mapping-component:
  feat(core): Manage version control settings (#6079)
  ci: Fix linting error on `master` (no-changelog) (#6075)
  ci: Increase the timeout on the release process (no-changelog) (#6078)
  fix(editor): Update LDAP and Log streaming paywalls (#6069)
  feat(core): Add instanceId to n8n.ready hook (no-changelog) (#6007)
  ci: Update linting dependencies, and setup eslint-plugin-unicorn (no-changelog) (#6070)
@janober
Copy link
Member

janober commented May 2, 2023

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants