Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Update LDAP and Log streaming paywalls #6069

Merged
merged 1 commit into from
Apr 24, 2023

Conversation

cstuncsik
Copy link
Contributor

No description provided.

@github-actions
Copy link
Contributor

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching **/*.vue:

  • Used composition API for all new components.
  • Added component or unit tests to cover functionality.

Files matching packages/editor-ui/**/*.vue:

  • Added E2E if adding new features.
  • Used design system tokens (colors, spacings...) where possible.

Make sure to check off this list before asking for review.

@codecov
Copy link

codecov bot commented Apr 24, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.05 ⚠️

Comparison is base (4bd55f7) 18.63% compared to head (cd2e66f) 18.59%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6069      +/-   ##
==========================================
- Coverage   18.63%   18.59%   -0.05%     
==========================================
  Files        2585     2585              
  Lines      116483   116654     +171     
  Branches    18181    18181              
==========================================
- Hits        21711    21686      -25     
- Misses      94134    94334     +200     
+ Partials      638      634       -4     

see 31 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Apr 24, 2023
@github-actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@cstuncsik cstuncsik merged commit 8a3b3e5 into master Apr 24, 2023
@cstuncsik cstuncsik deleted the pay-411-update-paywalls branch April 24, 2023 13:37
sunilrr pushed a commit to fl-g6/qp-n8n that referenced this pull request Apr 24, 2023
MiloradFilipovic added a commit that referenced this pull request Apr 25, 2023
* master:
  feat(core): Manage version control settings (#6079)
  ci: Fix linting error on `master` (no-changelog) (#6075)
  ci: Increase the timeout on the release process (no-changelog) (#6078)
  fix(editor): Update LDAP and Log streaming paywalls (#6069)
  feat(core): Add instanceId to n8n.ready hook (no-changelog) (#6007)
  ci: Update linting dependencies, and setup eslint-plugin-unicorn (no-changelog) (#6070)
MiloradFilipovic added a commit that referenced this pull request Apr 25, 2023
…rce-mapper-ui-P2

* feature/resource-mapping-component:
  feat(core): Manage version control settings (#6079)
  ci: Fix linting error on `master` (no-changelog) (#6075)
  ci: Increase the timeout on the release process (no-changelog) (#6078)
  fix(editor): Update LDAP and Log streaming paywalls (#6069)
  feat(core): Add instanceId to n8n.ready hook (no-changelog) (#6007)
  ci: Update linting dependencies, and setup eslint-plugin-unicorn (no-changelog) (#6070)
@janober
Copy link
Member

janober commented May 2, 2023

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants