Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(editor): Delete leftover restApi mixin file (no-changelog) #6074

Merged
merged 3 commits into from
Apr 24, 2023

Conversation

MiloradFilipovic
Copy link
Contributor

Github issue / Community forum post (link here to close automatically):

* master:
  refactor: Async functions don't need to explicitly return promises (no-changelog) (#6041)
  SSO/SAML : add Base URL to redirects in acsHandler (#5923)
  refactor: Integrate `consistent-type-imports` in FE packages (no-changelog) (#6060)
  fix(core): Skip license activation when instance was already activated (#6064)
  refactor(core): Setup decorator based RBAC (no-changelog) (#5787)

# Conflicts:
#	packages/editor-ui/src/mixins/restApi.ts
@MiloradFilipovic MiloradFilipovic self-assigned this Apr 24, 2023
@github-actions
Copy link
Contributor

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Files matching **/*.vue:

  • Used composition API for all new components.
  • Added component or unit tests to cover functionality.

Files matching packages/editor-ui/**/*.vue:

  • Added E2E if adding new features.
  • Used design system tokens (colors, spacings...) where possible.

Files matching packages/editor-ui/src/mixins/restApi.ts:

  • Avoided adding new methods. Only deleted from here.

Files matching packages/editor-ui/src/mixins/**:

  • Avoided adding new mixins (use composables instead). Only removed code from here.

Make sure to check off this list before asking for review.

alexgrozav
alexgrozav previously approved these changes Apr 24, 2023
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Apr 24, 2023
@github-actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@codecov
Copy link

codecov bot commented Apr 24, 2023

Codecov Report

Patch coverage: 50.00% and project coverage change: +0.03 🎉

Comparison is base (308a943) 18.59% compared to head (b693a0e) 18.63%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6074      +/-   ##
==========================================
+ Coverage   18.59%   18.63%   +0.03%     
==========================================
  Files        2585     2584       -1     
  Lines      116646   116413     -233     
  Branches    18181    18180       -1     
==========================================
- Hits        21694    21689       -5     
+ Misses      94318    94090     -228     
  Partials      634      634              
Impacted Files Coverage Δ
packages/editor-ui/src/stores/workflows.ts 31.55% <50.00%> (-0.18%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@MiloradFilipovic MiloradFilipovic merged commit 8886516 into master Apr 24, 2023
@MiloradFilipovic MiloradFilipovic deleted the definitely-delete-restAPI-mixin branch April 24, 2023 12:23
MiloradFilipovic added a commit that referenced this pull request Apr 24, 2023
* master:
  refactor(editor): Delete leftover restApi mixin file (no-changelog) (#6074)
  docs: Remove version notice from overhauled nodes (no-changelog) (#6071)
  refactor(editor): Combine type imports in `editor-ui` (no-changelog) (#6072)
  refactor: Async functions don't need to explicitly return promises (no-changelog) (#6041)
  SSO/SAML : add Base URL to redirects in acsHandler (#5923)
  refactor: Integrate `consistent-type-imports` in FE packages (no-changelog) (#6060)
  fix(core): Skip license activation when instance was already activated (#6064)
  refactor(core): Setup decorator based RBAC (no-changelog) (#5787)
  test: Add run linking tests (#6061)

# Conflicts:
#	packages/editor-ui/src/components/ParameterInputWrapper.vue
sunilrr pushed a commit to fl-g6/qp-n8n that referenced this pull request Apr 24, 2023
…8n-io#6074)

* refactor(editor): Delete leftover `restApi` mixin file (no-changelog)
* Removing leftover comment
@janober
Copy link
Member

janober commented May 2, 2023

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants