Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Remove version notice from overhauled nodes (no-changelog) #6071

Merged
merged 3 commits into from
Apr 24, 2023

Conversation

Joffcom
Copy link
Member

@Joffcom Joffcom commented Apr 24, 2023

Github issue / Community forum post (link here to close automatically):

@github-actions
Copy link
Contributor

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Files matching packages/nodes-base/nodes/**:

  • Added workflow tests for nodes if possible.

Make sure to check off this list before asking for review.

@codecov
Copy link

codecov bot commented Apr 24, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (03be725) 18.59% compared to head (348d60f) 18.59%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6071   +/-   ##
=======================================
  Coverage   18.59%   18.59%           
=======================================
  Files        2585     2585           
  Lines      116665   116665           
  Branches    18181    18181           
=======================================
  Hits        21694    21694           
  Misses      94337    94337           
  Partials      634      634           
Impacted Files Coverage Δ
.../nodes-base/nodes/EmailSend/v1/EmailSendV1.node.ts 0.00% <ø> (ø)
.../nodes/Google/BigQuery/v1/GoogleBigQueryV1.node.ts 9.47% <ø> (ø)
packages/nodes-base/nodes/MySql/v1/MySqlV1.node.ts 0.00% <ø> (ø)
...es/nodes-base/nodes/Postgres/v1/PostgresV1.node.ts 0.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Joffcom Joffcom changed the title docs: Remove version notice from Postgres Node (no-changelog) docs: Remove version notice from overhauled nodes (no-changelog) Apr 24, 2023
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team node/improvement New feature or request labels Apr 24, 2023
@github-actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@Joffcom Joffcom merged commit 871d419 into master Apr 24, 2023
@Joffcom Joffcom deleted the postgres-remove-version-notice branch April 24, 2023 12:21
MiloradFilipovic added a commit that referenced this pull request Apr 24, 2023
* master:
  refactor(editor): Delete leftover restApi mixin file (no-changelog) (#6074)
  docs: Remove version notice from overhauled nodes (no-changelog) (#6071)
  refactor(editor): Combine type imports in `editor-ui` (no-changelog) (#6072)
  refactor: Async functions don't need to explicitly return promises (no-changelog) (#6041)
  SSO/SAML : add Base URL to redirects in acsHandler (#5923)
  refactor: Integrate `consistent-type-imports` in FE packages (no-changelog) (#6060)
  fix(core): Skip license activation when instance was already activated (#6064)
  refactor(core): Setup decorator based RBAC (no-changelog) (#5787)
  test: Add run linking tests (#6061)

# Conflicts:
#	packages/editor-ui/src/components/ParameterInputWrapper.vue
@janober
Copy link
Member

janober commented May 2, 2023

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team node/improvement New feature or request Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants