-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Add run linking tests #6061
Conversation
Great PR! Please pay attention to the following items before merging: Files matching
Make sure to check off this list before asking for review. |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #6061 +/- ##
=======================================
Coverage 18.63% 18.63%
=======================================
Files 2585 2585
Lines 116483 116483
Branches 18181 18181
=======================================
Hits 21711 21711
Misses 94134 94134
Partials 638 638 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Passing run #595 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Left a minor comment but good to go without it.
workflowPage.actions.openNode('Set3'); | ||
|
||
ndv.getters.inputRunSelector() | ||
.should('exist') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this necessary? I think next find
should fail if the element is not there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if I understood correctly, this is like a wait until the element exists..
|
✅ All Cypress E2E specs passed |
* master: refactor(editor): Delete leftover restApi mixin file (no-changelog) (#6074) docs: Remove version notice from overhauled nodes (no-changelog) (#6071) refactor(editor): Combine type imports in `editor-ui` (no-changelog) (#6072) refactor: Async functions don't need to explicitly return promises (no-changelog) (#6041) SSO/SAML : add Base URL to redirects in acsHandler (#5923) refactor: Integrate `consistent-type-imports` in FE packages (no-changelog) (#6060) fix(core): Skip license activation when instance was already activated (#6064) refactor(core): Setup decorator based RBAC (no-changelog) (#5787) test: Add run linking tests (#6061) # Conflicts: # packages/editor-ui/src/components/ParameterInputWrapper.vue
* test: Add link/unlink test * test: Add run linking * test: uncomment other tests * test: change click * test: bring back tests, update click * test: fix flaky paired item test * test: update flaky tests * test: add timeouts * test: update import
Got released with |
Github issue / Community forum post (link here to close automatically):