Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add run linking tests #6061

Merged
merged 11 commits into from
Apr 24, 2023
Merged

test: Add run linking tests #6061

merged 11 commits into from
Apr 24, 2023

Conversation

mutdmour
Copy link
Contributor

Github issue / Community forum post (link here to close automatically):

@github-actions
Copy link
Contributor

github-actions bot commented Apr 21, 2023

Great PR! Please pay attention to the following items before merging:

Files matching cypress/e2e/**:

  • Avoided chaining commands more than two or three times (to avoid flakiness because only last one will be retried).
  • Spoofed endpoints that are not critical for the test (to avoid flakiness).
  • Picked most efficient path to start the test (for example skipped account setup and starting at /workflow/new for a canvas test).
  • Avoided adding waits on time (use request intercepts instead).
  • Ensured each spec does not depend on any another spec to pass.

Make sure to check off this list before asking for review.

@codecov
Copy link

codecov bot commented Apr 21, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (9c94050) 18.63% compared to head (01cfc9d) 18.63%.

❗ Current head 01cfc9d differs from pull request most recent head 5c8298a. Consider uploading reports for the commit 5c8298a to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6061   +/-   ##
=======================================
  Coverage   18.63%   18.63%           
=======================================
  Files        2585     2585           
  Lines      116483   116483           
  Branches    18181    18181           
=======================================
  Hits        21711    21711           
  Misses      94134    94134           
  Partials      638      638           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@n8n-assistant n8n-assistant bot added the n8n team Authored by the n8n team label Apr 21, 2023
@cypress
Copy link

cypress bot commented Apr 21, 2023

Passing run #595 ↗︎

0 217 0 0 Flakiness 0

Details:

🌳 linking-test 🖥️ base:16.18.1 🤖 mutasem 🗃️ e2e/*
Project: n8n Commit: 01cfc9d110
Status: Passed Duration: 07:18 💡
Started: Apr 24, 2023 7:51 AM Ended: Apr 24, 2023 7:59 AM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

Copy link
Contributor

@MiloradFilipovic MiloradFilipovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Left a minor comment but good to go without it.

workflowPage.actions.openNode('Set3');

ndv.getters.inputRunSelector()
.should('exist')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this necessary? I think next find should fail if the element is not there.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if I understood correctly, this is like a wait until the element exists..

@github-actions
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

cypress/e2e/5-ndv.cy.ts Outdated Show resolved Hide resolved
@mutdmour mutdmour requested a review from OlegIvaniv April 24, 2023 08:15
@github-actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@mutdmour mutdmour merged commit feb2ba0 into master Apr 24, 2023
@mutdmour mutdmour deleted the linking-test branch April 24, 2023 09:07
MiloradFilipovic added a commit that referenced this pull request Apr 24, 2023
* master:
  refactor(editor): Delete leftover restApi mixin file (no-changelog) (#6074)
  docs: Remove version notice from overhauled nodes (no-changelog) (#6071)
  refactor(editor): Combine type imports in `editor-ui` (no-changelog) (#6072)
  refactor: Async functions don't need to explicitly return promises (no-changelog) (#6041)
  SSO/SAML : add Base URL to redirects in acsHandler (#5923)
  refactor: Integrate `consistent-type-imports` in FE packages (no-changelog) (#6060)
  fix(core): Skip license activation when instance was already activated (#6064)
  refactor(core): Setup decorator based RBAC (no-changelog) (#5787)
  test: Add run linking tests (#6061)

# Conflicts:
#	packages/editor-ui/src/components/ParameterInputWrapper.vue
sunilrr pushed a commit to fl-g6/qp-n8n that referenced this pull request Apr 24, 2023
* test: Add link/unlink test

* test: Add run linking

* test: uncomment other tests

* test: change click

* test: bring back tests, update click

* test: fix flaky paired item test

* test: update flaky tests

* test: add timeouts

* test: update import
@janober
Copy link
Member

janober commented May 2, 2023

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants