Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(core): Remove linting exceptions in nodes-base #4794

Merged
merged 26 commits into from
Dec 2, 2022
Merged

refactor(core): Remove linting exceptions in nodes-base #4794

merged 26 commits into from
Dec 2, 2022

Conversation

michael-radency
Copy link
Contributor

No description provided.

@michael-radency michael-radency added n8n team Authored by the n8n team node/linting Applies rule from eslint-plugin-n8n-nodes-base labels Dec 2, 2022
@michael-radency michael-radency marked this pull request as draft December 2, 2022 09:15
@michael-radency
⚡ await-thenable on
3721797
@michael-radency
⚡ ban-types on
b5442ce
@michael-radency
Merge branch 'master' of https://github.com/n8n-io/n8n into n8n-5626-…
ae44257 
…remove-linting-exceptions-in-nodes-base
@michael-radency
⚡ default-param-last on
a16a5df
@michael-radency
⚡ dot-notation on
7914d11
@michael-radency
⚡ member-delimiter-style on
def2631
@michael-radency
Merge branch 'master' of https://github.com/n8n-io/n8n into n8n-5626-…
98c60bf 
…remove-linting-exceptions-in-nodes-base
@michael-radency
⚡ no-duplicate-imports on
f157794
@michael-radency
⚡ no-empty-interface on
24987a4
@michael-radency
⚡ no-floating-promises on
d1e0a77
@michael-radency
⚡ no-for-in-array on
f3ca250
@michael-radency
⚡ no-invalid-void-type on
9df0d34
@michael-radency
⚡ no-loop-func on
961192c
@michael-radency
⚡ no-shadow on
fe6ebb2
@michael-radency
Merge branch 'master' of https://github.com/n8n-io/n8n into n8n-5626-…
c0f1a8c 
…remove-linting-exceptions-in-nodes-base
@michael-radency
⚡ ban-ts-comment re enabled
06f1e62
@michael-radency michael-radency marked this pull request as ready for review December 2, 2022 16:28
netroy
netroy approved these changes Dec 2, 2022
View reviewed changes
Copy link
Member

@netroy netroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this. This will definitely make a lot of us happier. 🙏🏽
PS: I also added some commits made via eslint --fix

@netroy netroy merged commit 61e2680 into master Dec 2, 2022
@netroy netroy deleted the n8n-5626-remove-linting-exceptions-in-nodes-base branch December 2, 2022 20:54
@n8n-assistant n8n-assistant bot added the Upcoming Release Will be part of the upcoming release label Dec 2, 2022
MiloradFilipovic added a commit that referenced this pull request Dec 5, 2022
@MiloradFilipovic
Merge branch 'master' into feature/undo-redo
3e6477a 
* master:
  fix(core): Fix linter error (#4808)
  refactor(core): Remove linting exceptions in nodes-base (#4794)
  ci: Add run name and start url for e2e tests and docker nighly command (no-changelog) (#4800)
@janober
Copy link
Member

janober commented Dec 7, 2022

Got released with [email protected]

@janober janober removed the Upcoming Release Will be part of the upcoming release label Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@netroy netroy netroy approved these changes

Assignees
No one assigned
Labels
n8n team Authored by the n8n team node/linting Applies rule from eslint-plugin-n8n-nodes-base
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michael-radency @janober @netroy